Bugzilla – Attachment 51532 Details for
Bug 14610
Add ability to place article requests in Koha
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14610 [QA Followup] - Switch from Koha::Borrower to Koha::Patron
Bug-14610-QA-Followup---Switch-from-KohaBorrower-t.patch (text/plain), 3.47 KB, created by
Kyle M Hall (khall)
on 2016-05-16 13:42:33 UTC
(
hide
)
Description:
Bug 14610 [QA Followup] - Switch from Koha::Borrower to Koha::Patron
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-05-16 13:42:33 UTC
Size:
3.47 KB
patch
obsolete
>From 37d7115dce1a6e801857ad3f6eccc53b644e2e77 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 16 May 2016 11:32:43 +0000 >Subject: [PATCH] Bug 14610 [QA Followup] - Switch from Koha::Borrower to > Koha::Patron > >--- > circ/request-article.pl | 6 +++--- > opac/opac-request-article.pl | 4 ++-- > t/db_dependent/ArticleRequests.t | 8 ++++---- > 3 files changed, 9 insertions(+), 9 deletions(-) > >diff --git a/circ/request-article.pl b/circ/request-article.pl >index 6c083d5..0c76e6c 100755 >--- a/circ/request-article.pl >+++ b/circ/request-article.pl >@@ -23,7 +23,7 @@ use C4::Output; > use C4::Auth; > use C4::Utils::DataTables::Members; > use Koha::Biblios; >-use Koha::Borrowers; >+use Koha::Patrons; > use Koha::ArticleRequests; > > my $cgi = new CGI; >@@ -44,7 +44,7 @@ my $patron_cardnumber = $cgi->param('patron_cardnumber'); > my $patron_id = $cgi->param('patron_id'); > > my $biblio = Koha::Biblios->find($biblionumber); >-my $patron = Koha::Borrowers->find( >+my $patron = Koha::Patrons->find( > $patron_id ? $patron_id : { cardnumber => $patron_cardnumber } ); > > if ( $action eq 'create' ) { >@@ -89,7 +89,7 @@ if ( !$patron && $patron_cardnumber ) { > my $patrons = $results->{patrons}; > > if ( scalar @$patrons == 1 ) { >- $patron = Koha::Borrowers->find( $patrons->[0]->{borrowernumber} ); >+ $patron = Koha::Patrons->find( $patrons->[0]->{borrowernumber} ); > } > elsif (@$patrons) { > $template->param( patrons => $patrons ); >diff --git a/opac/opac-request-article.pl b/opac/opac-request-article.pl >index 5920366..b82b77a 100755 >--- a/opac/opac-request-article.pl >+++ b/opac/opac-request-article.pl >@@ -25,7 +25,7 @@ use C4::Auth; > use C4::Output; > > use Koha::Biblios; >-use Koha::Borrowers; >+use Koha::Patrons; > > my $cgi = new CGI; > >@@ -75,7 +75,7 @@ if ( $action eq 'create' ) { > } > > my $biblio = Koha::Biblios->find($biblionumber); >-my $patron = Koha::Borrowers->find($borrowernumber); >+my $patron = Koha::Patrons->find($borrowernumber); > > $template->param( > biblio => $biblio, >diff --git a/t/db_dependent/ArticleRequests.t b/t/db_dependent/ArticleRequests.t >index 55cb2bc..af9e1c8 100755 >--- a/t/db_dependent/ArticleRequests.t >+++ b/t/db_dependent/ArticleRequests.t >@@ -23,7 +23,7 @@ use Test::More tests => 49; > use Koha::Database; > > use Koha::Biblio; >-use Koha::Borrower; >+use Koha::Patron; > use Koha::Library; > > BEGIN { >@@ -61,13 +61,13 @@ ok( $item->id, 'Koha::Item created' ); > > my $branch = Koha::Libraries->search()->next(); > my $category = $schema->resultset('Category')->next(); >-my $patron = Koha::Borrower->new( >+my $patron = Koha::Patron->new( > { > categorycode => $category->id, > branchcode => $branch->id, > } > )->store(); >-ok( $patron->id, 'Koha::Borrower created' ); >+ok( $patron->id, 'Koha::Patron created' ); > > my $article_request = Koha::ArticleRequest->new( > { >@@ -91,7 +91,7 @@ $article_request->store(); > > is( $article_request->biblio->id, $biblio->id, '$ar->biblio() gets corrosponding Koha::Biblio object' ); > is( $article_request->item->id, $item->id, '$ar->item() gets corrosponding Koha::Item object' ); >-is( $article_request->borrower->id, $patron->id, '$ar->borrower() gets corrosponding Koha::Borrower object' ); >+is( $article_request->borrower->id, $patron->id, '$ar->borrower() gets corrosponding Koha::Patron object' ); > > my $ar = $patron->article_requests(); > is( ref($ar), 'Koha::ArticleRequests', '$patron->article_requests returns Koha::ArticleRequests object' ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14610
:
42822
|
42823
|
42824
|
42825
|
42826
|
42827
|
42828
|
42829
|
43198
|
43199
|
43200
|
43201
|
43202
|
43264
|
43265
|
43266
|
43267
|
43268
|
43270
|
43271
|
43272
|
43273
|
43274
|
43278
|
43279
|
43280
|
43281
|
43282
|
43654
|
43655
|
43656
|
43657
|
43658
|
44219
|
44220
|
44221
|
44222
|
44223
|
44224
|
44225
|
44226
|
44227
|
44228
|
44229
|
44230
|
44231
|
44232
|
44233
|
44234
|
44235
|
44236
|
44237
|
44238
|
44239
|
44240
|
44241
|
44242
|
44916
|
44917
|
44918
|
44919
|
44920
|
44921
|
44922
|
44923
|
44924
|
44925
|
44926
|
45946
|
45947
|
45948
|
45949
|
45950
|
45951
|
45952
|
45953
|
45954
|
45955
|
45956
|
46518
|
46519
|
46520
|
46521
|
46522
|
46523
|
46524
|
46525
|
46526
|
46527
|
46528
|
46529
|
46530
|
46595
|
46596
|
46597
|
46598
|
46599
|
46600
|
46601
|
46602
|
46603
|
46604
|
46605
|
46606
|
46607
|
46608
|
46609
|
46610
|
46611
|
46612
|
47905
|
47906
|
47907
|
47908
|
47909
|
47910
|
47911
|
47912
|
47913
|
47914
|
47915
|
47916
|
47917
|
47918
|
47919
|
47920
|
47921
|
47922
|
48177
|
48178
|
48179
|
48180
|
48181
|
48182
|
48212
|
48213
|
48214
|
48215
|
48216
|
48217
|
48218
|
50348
|
50349
|
50350
|
50351
|
50352
|
50353
|
50354
|
51527
|
51528
|
51529
|
51530
|
51531
|
51532
|
51533
|
51534
|
51778
|
51779
|
51780
|
51781
|
51782
|
51783
|
52688
|
52689
|
52690
|
52691
|
52692
|
52693
|
55556
|
55557
|
55558
|
55559
|
55560
|
55561
|
55568
|
55569
|
56084
|
56085
|
56086
|
56087
|
56088
|
56089
|
56090
|
56318
|
56319
|
56320
|
56321
|
56322
|
56323
|
56324
|
56325
|
56326
|
56327
|
56328
|
56775
|
56776
|
56777
|
56778
|
56779
|
56780
|
56781
|
56782
|
56783
|
56784
|
56785
|
56816
|
56854
|
56855
|
56856
|
56857
|
56858
|
56859
|
56860
|
56861
|
56862
|
56863
|
56864
|
56865