Attachment 5155 Details for Bug 6458 – Proposed fix for opac-reserve.tt

[patch] Proposed fix for opac-reserve.tt

0001-Fix-for-Bug-6458-incorrect-parsing-opac-holds.patch (text/plain), 3.65 KB, created by Owen Leonard on 2011-08-26 13:33:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2011-08-26 13:33:35 UTC

Size: 3.65 KB

patch

obsolete

>From 75c6ab7fc50d375b8114c4122664ee9ae23413bf Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 25 Aug 2011 15:37:25 -0400
>Subject: [PATCH] Fix for Bug 6458 - incorrect parsing result in translation processing
>Content-Type: text/plain; charset="utf-8"
>
>Correction in opac holds template. Corrections made are logically
>consistent, but I couldn't reproduce the combination of factors
>to trigger the "disabled" attribute on the branch selector. In
>that respect this hasn't been tested 100%.
>---
> .../opac-tmpl/prog/en/modules/opac-reserve.tt      |   33 +++++++++++++------
> 1 files changed, 22 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
>index 4d81a17..543b469 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
>@@ -423,17 +423,28 @@
>                         [% IF ( bibitemloo.holdable ) %]
> 			    [% IF ( choose_branch ) %]
> 			                   <td>
>-                                              <select name="branch" id="branch_[% bibitemloo.biblionumber %]"
>-                                                [% UNLESS ( bibitemloo.holdable ) %]disabled="disabled"[% END %] >
>-                                                [% FOREACH branchChoicesLoo IN bibitemloo.branchChoicesLoop %]
>-                                                  [% IF ( branchChoicesLoo.selected ) %]
>-                                                    <option value="[% branchChoicesLoo.value %]" selected="selected">[% branchChoicesLoo.branchname %]</option>
>-                                                  [% ELSE %]
>-                                                    <option value="[% branchChoicesLoo.value %]">[% branchChoicesLoo.branchname %]</option>
>-                                                  [% END %]
>-                                                [% END %]
>-                                              </select>
>-                                           </td>
>+                         [% UNLESS ( bibitemloo.holdable ) %]
>+                            <select name="branch" id="branch_[% bibitemloo.biblionumber %]" disabled="disabled">
>+                              [% FOREACH branchChoicesLoo IN bibitemloo.branchChoicesLoop %]
>+                                [% IF ( branchChoicesLoo.selected ) %]
>+                                  <option value="[% branchChoicesLoo.value %]" selected="selected">[% branchChoicesLoo.branchname %]</option>
>+                                [% ELSE %]
>+                                  <option value="[% branchChoicesLoo.value %]">[% branchChoicesLoo.branchname %]</option>
>+                                [% END %]
>+                              [% END %]
>+                          </select>
>+                          [% ELSE %]
>+                            <select name="branch" id="branch_[% bibitemloo.biblionumber %]">
>+                              [% FOREACH branchChoicesLoo IN bibitemloo.branchChoicesLoop %]
>+                                [% IF ( branchChoicesLoo.selected ) %]
>+                                  <option value="[% branchChoicesLoo.value %]" selected="selected">[% branchChoicesLoo.branchname %]</option>
>+                                [% ELSE %]
>+                                  <option value="[% branchChoicesLoo.value %]">[% branchChoicesLoo.branchname %]</option>
>+                                [% END %]
>+                              [% END %]
>+                            </select>
>+                          [% END %]
>+                       </td>
> 			    [% END %]
> 		        [% END %]
>                     [% END %]
>-- 
>1.7.3
>

Actions: View | Diff | Splinter Review

Attachments on bug 6458: 4695 | 4697 | 4699 | 4729 | 4968 | 5070 | 5071 | 5072 | 5074 | 5078 | 5079 | 5080 | 5081 | 5082 | 5090 | 5091 | 5092 | 5093 | 5094 | 5095 | 5096 | 5121 | 5125 | 5126 | 5127 | 5128 | 5129 | 5130 | 5131 | 5132 | 5133 | 5147 | 5148 | 5149 | 5150 | 5152 | 5153 | 5155 | 5156 | 5157 | 5158 | 5159 | 5160 | 5168 | 5169 | 5170 | 5258 | 5259 | 5260 | 5261 | 5262 | 5263 | 5273 | 5274 | 5286 | 5287 | 5288 | 5289 | 5292 | 5293 | 5299 | 5300 | 5416 | 5417 | 5418 | 5419 | 5420 | 5425 | 5426 | 5427