Attachment 51560 Details for Bug 16532 – Bug 16523: Groups showing empty tables if no groups defined

[patch] Bug 16523: Groups showing empty tables if no groups defined

Bug-16523-Groups-showing-empty-tables-if-no-groups.patch (text/plain), 1.35 KB, created by Aleisha Amohia on 2016-05-17 05:08:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2016-05-17 05:08:38 UTC

Size: 1.35 KB

patch

obsolete

>From da1eeeba186248414ea3fa13f9b2efcb231ddf2d Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Tue, 17 May 2016 05:04:08 +0000
>Subject: [PATCH] Bug 16523: Groups showing empty tables if no groups defined
>
>To test:
>1) Go to Admin -> Libraries and Groups
>2) Notice empty tables if nothing defined
>3) Apply patch and refresh page
>4) Empty tables should not show
>5) Add a new group
>6) Confirm table shows correctly
>
>Sponsored-by: Catalyst IT
>
>https://bugs.koha-community.org/show_bug.cgi?id=16532
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>index b698a86..0920450 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>@@ -283,7 +283,7 @@ tinyMCE.init({
>     [% IF group_types %]
>         [% FOREACH group_type IN group_types %]
>             <h3>[% IF group_type.categorytype == 'properties' %]Properties[% ELSIF group_type.categorytype == 'searchdomain' %]Search domain[% END %]</h3>
>-            [% IF group_type.categories %]
>+            [% IF group_type.categories.size %]
>                 <table>
>                     <thead>
>                         <tr>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 16532: 51558 | 51560 | 51561 | 51730 | 51767 | 51803