Attachment 51584 Details for Bug 16001 – Bug 16001 - Use standard message dialog when there are no cities to list

[patch] Bug 16001 - Use standard message dialog when there are no cities to list

Bug-16001---Use-standard-message-dialog-when-there.patch (text/plain), 1.69 KB, created by Owen Leonard on 2016-05-17 18:36:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2016-05-17 18:36:12 UTC

Size: 1.69 KB

patch

obsolete

>From d632f35bb6e30ca17c16b5e252e062c85b70f0b2 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 7 Mar 2016 12:12:40 -0500
>Subject: [PATCH] Bug 16001 - Use standard message dialog when there are no
> cities to list
>Content-Type: text/plain; charset="utf-8"
>
>If there are no existing cities in Administration -> Cities and Towns,
>the message saying so should be in the standard message dialog.
>
>Another minor change: Edit the message to say "There are no cities
>defined," which I think reads better in English.
>
>To test you must have no cities and towns defined.
>
>Apply this patch and go to Administration -> Cities and Towns. You
>should see a message displayed in a standard "message" style dialog.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt
>index f6a85ea..a380a45 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt
>@@ -146,7 +146,7 @@
>         Searching: [% searchfield %]
>     [% END %]
> 
>-    [% IF cities %]
>+    [% IF cities.count %]
>         <table id="table_cities">
>             <thead>
>                 <th>City ID</th>
>@@ -172,7 +172,9 @@
>             </tbody>
>         </table>
>     [% ELSE %]
>-        There is no city defined. <a href="/cgi-bin/koha/admin/cities.pl?op=add_form">Create a new city</a>.
>+        <div class="dialog message">
>+            There are no cities defined. <a href="/cgi-bin/koha/admin/cities.pl?op=add_form">Create a new city</a>.
>+        </div>
>     [% END %]
> [% END %]
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16001: 48760 | 51584 | 51623 | 51667