Attachment 51588 Details for Bug 16539 – Bug 16539 - Koha::Cache is incorrectly caching single holidays

[patch] Bug 16539 - Koha::Cache is incorrectly caching single holidays

Bug-16539---KohaCache-is-incorrectly-caching-singl.patch (text/plain), 1.32 KB, created by Chris Cormack on 2016-05-17 23:50:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2016-05-17 23:50:57 UTC

Size: 1.32 KB

patch

obsolete

>From 7dd165c10f96e8b7baa838a87592ca6f9b9990e6 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 17 May 2016 14:39:49 -0400
>Subject: [PATCH] Bug 16539 - Koha::Cache is incorrectly caching single
> holidays
>
>This makes the loop add holidays for each bracnh instead of the calling
>branch
>
>To test:
>I used memcached-tools to view the cache, clear the cache, and wait for
>holidays to regnerate
>
>Have a branches with different holidays
>Clear the cache
>Do a checkout
>View the cache - one libraries holidays are repeated for all branches
>Apply patch
>Clear the cache
>Do a checkout
>Library holidays are correctly cached
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> Koha/Calendar.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Calendar.pm b/Koha/Calendar.pm
>index 7095aca..6bebf73 100644
>--- a/Koha/Calendar.pm
>+++ b/Koha/Calendar.pm
>@@ -116,7 +116,7 @@ sub single_holidays {
>             my $single_holidays_sth = $dbh->prepare(
> 'SELECT day, month, year FROM special_holidays WHERE branchcode = ? AND isexception = 0'
>             );
>-            $single_holidays_sth->execute($branchcode);
>+            $single_holidays_sth->execute($br);
> 
>             my @ymd_arr;
>             while ( my ( $day, $month, $year ) =
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 16539: 51585 | 51587 | 51588 | 51593 | 51664 | 51665 | 51666