Attachment 51692 Details for Bug 15878 – Bug 15878 - QA Followup

[patch] Bug 15878 - QA Followup

Bug-15878---QA-Followup.patch (text/plain), 1.68 KB, created by Nick Clemens (kidclamp) on 2016-05-22 00:20:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2016-05-22 00:20:55 UTC

Size: 1.68 KB

patch

obsolete

>From 744d2779e29513045756ebe8d27a01db22df87b4 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Sat, 21 May 2016 19:41:37 -0400
>Subject: [PATCH] Bug 15878 - QA Followup
>
>* Remove debug statment
>* Move transcation start
>* Remove unused testbuilder object
>
>Rebased on top of 16561
>---
> t/db_dependent/Barcodes.t | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
>diff --git a/t/db_dependent/Barcodes.t b/t/db_dependent/Barcodes.t
>index 0ff61af..3a504fc 100755
>--- a/t/db_dependent/Barcodes.t
>+++ b/t/db_dependent/Barcodes.t
>@@ -83,22 +83,15 @@ $schema->storage->txn_begin;
> };
> 
> 
>-$schema->storage->txn_begin;
>-
> subtest 'Test generation of hbyymmincr barcodes from DB values' => sub {
> 
>+    $schema->storage->txn_begin;
>     plan tests => 5;
> 
>     $builder->schema->resultset( 'Issue' )->delete_all;
>     $builder->schema->resultset( 'Item' )->delete_all;
> 
>-    my$barcode_branch = $builder->build({
>-            source => 'Branch',
>-            branchcode => 'LETTERS',
>-            });
>-
>-    my $branchcode_1 = "LETT";
>-    print "$branchcode_1\n";
>+    my $branchcode_1 = "LETTERS"; #NOTE: This barcode type supports only letters in the branchcode
>     my $barcodeobj;
> 
>     warnings_are { $barcodeobj = C4::Barcodes->new('hbyymmincr'); }
>@@ -145,6 +138,9 @@ subtest 'Test generation of hbyymmincr barcodes from DB values' => sub {
>     $schema->storage->txn_rollback;
> };
> 
>+
>+$schema->storage->txn_begin;
>+
> $builder->schema->resultset( 'Issue' )->delete_all;
> $builder->schema->resultset( 'Item' )->delete_all;
> 
>@@ -246,5 +242,5 @@ foreach $format (@formats) {
>     }
> }
> 
>-    $schema->storage->txn_rollback;
>+$schema->storage->txn_rollback;
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15878: 51477 | 51478 | 51479 | 51624 | 51625 | 51688 | 51690 | 51691 | 51692 | 51694 | 51695