Attachment 51722 Details for Bug 16499 – Bug 16499 [QA Followup] - Improve readability

[patch] Bug 16499 [QA Followup] - Improve readability

Bug-16499-QA-Followup---Improve-readability.patch (text/plain), 1.36 KB, created by Kyle M Hall (khall) on 2016-05-23 17:35:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2016-05-23 17:35:19 UTC

Size: 1.36 KB

patch

obsolete

>From 310c7df295f4fafb0099ff80b6a1fdf6cca3f6f6 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 23 May 2016 17:34:29 +0000
>Subject: [PATCH] Bug 16499 [QA Followup] - Improve readability
>
>---
> circ/circulation.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/circ/circulation.pl b/circ/circulation.pl
>index 136b7bf..b2bcdd1 100755
>--- a/circ/circulation.pl
>+++ b/circ/circulation.pl
>@@ -81,7 +81,7 @@ if (!C4::Context->userenv){
> my $barcodes = [];
> my $barcode =  $query->param('barcode');
> # Barcode given by user could be '0'
>-if ( $barcode or defined $barcode and $barcode eq '0' ) {
>+if ( $barcode || ( defined($barcode) && $barcode eq '0' ) ) {
>     $barcodes = [ $barcode ];
> } else {
>     my $filefh = $query->upload('uploadfile');
>@@ -167,7 +167,7 @@ my $duedatespec    = $query->param('duedatespec')   || $session->param('stickydu
> $duedatespec = eval { output_pref( { dt => dt_from_string( $duedatespec ), dateformat => 'iso' }); }
>     if ( $duedatespec );
> my $restoreduedatespec  = $query->param('restoreduedatespec') || $session->param('stickyduedate') || $duedatespec;
>-if ($restoreduedatespec and $restoreduedatespec eq "highholds_empty") {
>+if ( $restoreduedatespec && $restoreduedatespec eq "highholds_empty" ) {
>     undef $restoreduedatespec;
> }
> my $issueconfirmed = $query->param('issueconfirmed');
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16499: 51436 | 51440 | 51635 | 51721 | 51722