Attachment 51767 Details for Bug 16532 – [SIGNED-OFF] Bug 16532: Groups showing empty tables if no groups defined

[patch] [SIGNED-OFF] Bug 16532: Groups showing empty tables if no groups defined

SIGNED-OFF-Bug-16532-Groups-showing-empty-tables-i.patch (text/plain), 1.64 KB, created by Owen Leonard on 2016-05-25 12:06:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2016-05-25 12:06:13 UTC

Size: 1.64 KB

patch

obsolete

>From ff3e660212a3fc34ace14694ea557eeb339882a1 Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Tue, 17 May 2016 05:04:08 +0000
>Subject: [PATCH] [SIGNED-OFF] Bug 16532: Groups showing empty tables if no
> groups defined
>Content-Type: text/plain; charset="utf-8"
>
>EDIT: Same change for libraries
>
>To test:
>1) Go to Admin -> Libraries and Groups
>2) Notice empty tables if nothing defined
>3) Apply patch and refresh page
>4) Empty tables should not show
>5) Add a new group
>6) Confirm table shows correctly
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>index b698a86..77356ac 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>@@ -218,7 +218,7 @@ tinyMCE.init({
> 
> [% IF op == 'list' %]
>     <h3>Libraries</h3>
>-    [% IF libraries %]
>+    [% IF libraries.count %]
>         <table id="branchest">
>             <thead>
>                 <tr>
>@@ -283,7 +283,7 @@ tinyMCE.init({
>     [% IF group_types %]
>         [% FOREACH group_type IN group_types %]
>             <h3>[% IF group_type.categorytype == 'properties' %]Properties[% ELSIF group_type.categorytype == 'searchdomain' %]Search domain[% END %]</h3>
>-            [% IF group_type.categories %]
>+            [% IF group_type.categories.size %]
>                 <table>
>                     <thead>
>                         <tr>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16532: 51558 | 51560 | 51561 | 51730 | 51767 | 51803