Attachment 51805 Details for Bug 16502 – [SIGNED-OFF] Bug 16502: Adjust test for GetPlugins

[patch] [SIGNED-OFF] Bug 16502: Adjust test for GetPlugins

Bug-16502-Adjust-test-for-GetPlugins.patch (text/plain), 1.35 KB, created by Srdjan Jankovic on 2016-05-26 00:02:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Srdjan Jankovic

Created: 2016-05-26 00:02:25 UTC

Size: 1.35 KB

patch

obsolete

>From dd0b23869a4638e42fa5a9a02a906200a2c43838 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 23 May 2016 08:58:02 +0200
>Subject: [PATCH] Bug 16502: Adjust test for GetPlugins
>
>The current test assumes that GetPlugins will return the test plugin
>as the first one in the array. This is not correct.
>This patch adjusts the test to a grep.
>
>Test plan:
>Run the test.
>Bonus: Add additional plugins. Run the test again.
>
>Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
>---
> t/db_dependent/Plugins.t | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Plugins.t b/t/db_dependent/Plugins.t
>index 308e215..73ce65b 100755
>--- a/t/db_dependent/Plugins.t
>+++ b/t/db_dependent/Plugins.t
>@@ -43,7 +43,8 @@ ok( $plugin->get_qualified_table_name('mytable') eq 'koha_plugin_test_mytable',
> ok( $plugin->get_plugin_http_path() eq '/plugin/Koha/Plugin/Test', 'Test $plugin->get_plugin_http_path()' );
> 
> my @plugins = Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins( 'report' );
>-ok( $plugins[0]->get_metadata()->{'name'} eq 'Test Plugin', "Koha::Plugins::GetPlugins functions correctly" );
>+my @names = map { $_->get_metadata()->{'name'} } @plugins;
>+is( scalar grep( /^Test Plugin$/, @names), 1, "Koha::Plugins::GetPlugins functions correctly" );
> 
> SKIP: {
>     my $plugins_dir = C4::Context->config("pluginsdir");
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 16502: 51544 | 51545 | 51713 | 51714 | 51804 | 51805 | 51806 | 51853 | 51854 | 51855 | 51856 | 52260 | 52261 | 52262 | 52263