Attachment 51806 Details for Bug 16502 – [SIGNED-OFF] Bug 16502: Replace a few other ok-calls by is-calls

[patch] [SIGNED-OFF] Bug 16502: Replace a few other ok-calls by is-calls

Bug-16502-Replace-a-few-other-ok-calls-by-is-calls.patch (text/plain), 1.96 KB, created by Srdjan Jankovic on 2016-05-26 00:03:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Srdjan Jankovic

Created: 2016-05-26 00:03:55 UTC

Size: 1.96 KB

patch

obsolete

>From e7c9ccddf41810bcc3045cdc0f4e3bbcc0357956 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 23 May 2016 09:03:23 +0200
>Subject: [PATCH] Bug 16502: Replace a few other ok-calls by is-calls
>
>Trivial changes that speak for themselves..
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
>---
> t/db_dependent/Plugins.t | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/Plugins.t b/t/db_dependent/Plugins.t
>index 73ce65b..403d7c4 100755
>--- a/t/db_dependent/Plugins.t
>+++ b/t/db_dependent/Plugins.t
>@@ -34,13 +34,13 @@ ok( $plugin->can('configure'), 'Test plugin can configure' );
> ok( $plugin->can('install'), 'Test plugin can install' );
> ok( $plugin->can('uninstall'), 'Test plugin can install' );
> 
>-ok( Koha::Plugins::Handler->run({ class => "Koha::Plugin::Test", method => 'report', enable_plugins => 1 }) eq "Koha::Plugin::Test::report", 'Test run plugin report method' );
>+is( Koha::Plugins::Handler->run({ class => "Koha::Plugin::Test", method => 'report', enable_plugins => 1 }), "Koha::Plugin::Test::report", 'Test run plugin report method' );
> 
> my $metadata = $plugin->get_metadata();
>-ok( $metadata->{'name'} eq 'Test Plugin', 'Test $plugin->get_metadata()' );
>+is( $metadata->{'name'}, 'Test Plugin', 'Test $plugin->get_metadata()' );
> 
>-ok( $plugin->get_qualified_table_name('mytable') eq 'koha_plugin_test_mytable', 'Test $plugin->get_qualified_table_name()' );
>-ok( $plugin->get_plugin_http_path() eq '/plugin/Koha/Plugin/Test', 'Test $plugin->get_plugin_http_path()' );
>+is( $plugin->get_qualified_table_name('mytable'), 'koha_plugin_test_mytable', 'Test $plugin->get_qualified_table_name()' );
>+is( $plugin->get_plugin_http_path(), '/plugin/Koha/Plugin/Test', 'Test $plugin->get_plugin_http_path()' );
> 
> my @plugins = Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins( 'report' );
> my @names = map { $_->get_metadata()->{'name'} } @plugins;
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 16502: 51544 | 51545 | 51713 | 51714 | 51804 | 51805 | 51806 | 51853 | 51854 | 51855 | 51856 | 52260 | 52261 | 52262 | 52263