Attachment 51821 Details for Bug 16569 – Bug 16569 - Message box for "too many checked out" is empty if AllowTooManyOverride is not enabled

[patch] Bug 16569 - Message box for "too many checked out" is empty if AllowTooManyOverride is not enabled

Bug-16569---Message-box-for-too-many-checked-out-i.patch (text/plain), 1.49 KB, created by Jonathan Druart on 2016-05-26 10:13:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-05-26 10:13:31 UTC

Size: 1.49 KB

patch

obsolete

>From c9277532560c6aff29da6acfe0a405e959006057 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 23 May 2016 14:28:10 +0000
>Subject: [PATCH] Bug 16569 - Message box for "too many checked out" is empty
> if AllowTooManyOverride is not enabled
>
>If the limit for number of items checked out is reached, the message box
>shows up but is empty.
>
>Test Plan:
>1) Disable AllowTooManyOverride
>2) Check out items to a patron until the patron has reached the limit
>   of checkouts he or she can have
>3) Try to check out one more item
>4) Note the empty message box
>5) Apply this patch
>6) Try to check out one more item again
>7) Note the message is now visible
>
>Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> C4/Circulation.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 913ec0b..50e6c10 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -934,7 +934,7 @@ sub CanBookBeIssued {
>             $needsconfirmation{current_loan_count} = $toomany->{count};
>             $needsconfirmation{max_loans_allowed} = $toomany->{max_allowed};
>         } else {
>-            $needsconfirmation{TOO_MANY} = $toomany->{reason};
>+            $issuingimpossible{TOO_MANY} = $toomany->{reason};
>             $issuingimpossible{current_loan_count} = $toomany->{count};
>             $issuingimpossible{max_loans_allowed} = $toomany->{max_allowed};
>         }
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 16569: 51720 | 51816 | 51821