Bugzilla – Attachment 52012 Details for
Bug 16468
Remove last "onclick" from the stage MARC records template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16468 - Remove last "onclick" from the stage MARC records template
Bug-16468---Remove-last-onclick-from-the-stage-MAR.patch (text/plain), 2.96 KB, created by
Claire Gravely
on 2016-06-03 14:03:13 UTC
(
hide
)
Description:
Bug 16468 - Remove last "onclick" from the stage MARC records template
Filename:
MIME Type:
Creator:
Claire Gravely
Created:
2016-06-03 14:03:13 UTC
Size:
2.96 KB
patch
obsolete
>From 0761c513f21668ad410adbfdd703bc38bc46dd5c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 6 May 2016 12:15:33 -0400 >Subject: [PATCH] Bug 16468 - Remove last "onclick" from the stage MARC records > template > >This patch reviseds the stage MARC records template, removing >one more "onclick" attribute from the markup and defining that event in >the script. > >This patch also corrects a missing quotation mark in the HTML. I have >done some reindentation to that section. > >To test, apply the patch and go to Tools -> Stage MARC records for >import. > >- Select a MARC file for import. >- Click the "Upload file" button. >- Click the "Stage for import" button. Your import should be correctly > staged. > >Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> >--- > .../prog/en/modules/tools/stage-marc-import.tt | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt >index af24281..529edd5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt >@@ -31,6 +31,9 @@ $(document).ready(function(){ > e.preventDefault(); > CancelUpload(); > }); >+ $("#mainformsubmit").on("click",function(){ >+ return CheckForm( document.getElementById("processfile")); >+ }); > }); > function CheckForm(f) { > if ($("#fileToUpload").value == '') { >@@ -179,7 +182,14 @@ function cbUpload( status, fileid ) { > </li> > <li> > <label for="encoding">Character encoding: </label> >- <select name="encoding" id="encoding"><option value="utf8" selected="selected">UTF-8 (Default)</option><option value="MARC-8">MARC 8</option><option value="ISO_5426">ISO 5426</option><option value="ISO_6937">ISO 6937</option><option value=ISO_8859-1">ISO 8859-1</option><option value="EUC-KR">EUC-KR</option></select> >+ <select name="encoding" id="encoding"> >+ <option value="utf8" selected="selected">UTF-8 (Default)</option> >+ <option value="MARC-8">MARC 8</option> >+ <option value="ISO_5426">ISO 5426</option> >+ <option value="ISO_6937">ISO 6937</option> >+ <option value="ISO_8859-1">ISO 8859-1</option> >+ <option value="EUC-KR">EUC-KR</option> >+ </select> > </li> > </ol></fieldset> > >@@ -254,7 +264,7 @@ function cbUpload( status, fileid ) { > </li> > </ol> > </fieldset> >- <fieldset class="action"><input type="button" id="mainformsubmit" onclick="return CheckForm(this.form);" value="Stage for import" /></fieldset> >+ <fieldset class="action"><input type="button" id="mainformsubmit" value="Stage for import" /></fieldset> > > <div id="jobpanel"><div id="jobstatus">Job progress: <div id="jobprogress"></div> <span id="jobprogresspercent">0</span>%</div> > <div id="jobfailed"></div></div> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16468
:
51296
|
52012
|
52650