Bugzilla – Attachment 52062 Details for
Bug 16667
Unused variable and function call in circulation.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16667: Unused variable and function call in circulation.pl
Bug-16667-Unused-variable-and-function-call-in-cir.patch (text/plain), 1.09 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-06-05 11:55:14 UTC
(
hide
)
Description:
Bug 16667: Unused variable and function call in circulation.pl
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-06-05 11:55:14 UTC
Size:
1.09 KB
patch
obsolete
>From ead53712ee2fb2802f9bb8e05fecb653f752284a Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Sun, 5 Jun 2016 08:46:06 -0300 >Subject: [PATCH] Bug 16667: Unused variable and function call in > circulation.pl > >This patch removes an unused occurence of the $branches variable. Probably a >leftover from a recent rewrite. > >To test: >- Run: > $ git grep '$branches' circ/circulation.pl >=> FAIL: Only on occurence of the variable >- Apply the patch >- Run: > $ git grep '$branches' circ/circulation.pl >=> SUCCESS: The variable has been removed >- Sign off :-D > >Regards >--- > circ/circulation.pl | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index b2bcdd1..b2201cf 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -125,8 +125,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user ( > } > ); > >-my $branches = GetBranches(); >- > my $force_allow_issue = $query->param('forceallow') || 0; > if (!C4::Auth::haspermission( C4::Context->userenv->{id} , { circulate => 'force_checkout' } )) { > $force_allow_issue = 0; >-- >2.8.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16667
:
52062
|
52067
|
52112