Bugzilla – Attachment 52069 Details for
Bug 16636
t/00-load.t warning from C4/External/BakerTaylor.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 16636: t/00-load.t warning from C4/External/BakerTaylor.pm
Bug-16636-t00-loadt-warning-from-C4ExternalBakerTa.patch (text/plain), 1.40 KB, created by
Srdjan Jankovic
on 2016-06-06 05:28:01 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 16636: t/00-load.t warning from C4/External/BakerTaylor.pm
Filename:
MIME Type:
Creator:
Srdjan Jankovic
Created:
2016-06-06 05:28:01 UTC
Size:
1.40 KB
patch
obsolete
>From 32a83fdaaa35ee08a4107ec7c4c2a367f0ff6a3d Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 1 Jun 2016 20:43:30 -0400 >Subject: [PATCH] Bug 16636: t/00-load.t warning from > C4/External/BakerTaylor.pm > >Since the tests are expecting an initialize function, the >initialize call was just moved outside of the INIT block. > >TEST PLAN >--------- >1) prove t/00-load.t > -- warnings about INIT for hbyymmincr >2) prove `git grep -l BakerTaylor | grep [.]t$` > -- should all run okay >3) apply patch >4) repeat steps 1 and 2 > -- warning should be gone, and everything else run okay >5) run koha qa test tools > >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >--- > C4/External/BakerTaylor.pm | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/C4/External/BakerTaylor.pm b/C4/External/BakerTaylor.pm >index 4450e9b..3f52a57 100644 >--- a/C4/External/BakerTaylor.pm >+++ b/C4/External/BakerTaylor.pm >@@ -29,6 +29,7 @@ use warnings; > > use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $VERSION); > use vars qw($user $pass $agent $image_url $link_url); >+&initialize; > > BEGIN { > require Exporter; >@@ -37,9 +38,6 @@ BEGIN { > @EXPORT_OK = qw(&availability &content_cafe &image_url &link_url &http_jacket_link); > %EXPORT_TAGS = (all=>\@EXPORT_OK); > } >-INIT { >- &initialize; >-} > > sub initialize { > $user = (@_ ? shift : C4::Context->preference('BakerTaylorUsername') ) || ''; # LL17984 >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16636
:
51957
|
52069
|
52104
|
52213
|
52214
|
52215
|
52253