Bugzilla – Attachment 5210 Details for
Bug 6724
Holds Ratio does not allow decimals
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Signed-off patches, squashed
0001-SIGNED-OFF-bug-6724-enable-decimals-on-values-greate.patch (text/plain), 1.52 KB, created by
Owen Leonard
on 2011-08-29 14:26:30 UTC
(
hide
)
Description:
Signed-off patches, squashed
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-08-29 14:26:30 UTC
Size:
1.52 KB
patch
obsolete
>From 9d974703686c6b6a7a15a5552a7e61fc25706e3e Mon Sep 17 00:00:00 2001 >From: Brett Wilkins <brett@catalyst.net.nz> >Date: Mon, 29 Aug 2011 16:47:48 +1200 >Subject: [PATCH] [SIGNED-OFF] bug 6724: enable decimals on values greater than 1 >Content-Type: text/plain; charset="utf-8" > >Separating perl standard uses from koha uses > >http://bugs.koha-community.org/show_bug.cgi?id=6724 >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > circ/reserveratios.pl | 11 +++++++---- > 1 files changed, 7 insertions(+), 4 deletions(-) > >diff --git a/circ/reserveratios.pl b/circ/reserveratios.pl >index 5a86675..1517adf 100755 >--- a/circ/reserveratios.pl >+++ b/circ/reserveratios.pl >@@ -21,13 +21,14 @@ > use strict; > use warnings; > >+use CGI; >+use Date::Calc qw/Today Add_Delta_YM/; >+ > use C4::Context; > use C4::Output; >-use CGI; > use C4::Auth; > use C4::Dates qw/format_date format_date_in_iso/; > use C4::Debug; >-use Date::Calc qw/Today Add_Delta_YM/; > use C4::Biblio qw/GetMarcBiblio GetRecordValue GetFrameworkCode/; > > my $input = new CGI; >@@ -61,10 +62,12 @@ if (!defined($startdate) or $startdate !~ s/^\s*(\S+)\s*$/$1/) { # strip space > if (!defined($enddate) or $enddate !~ s/^\s*(\S+)\s*$/$1/) { # strip spaces, remove Taint > $enddate = format_date($todaysdate); > } >-if (!defined($ratio) or $ratio !~ s/^\s*(0?\.?\d+)(\.0*)?\s*$/$1/) { # strip spaces, remove Taint >+if (!defined($ratio)) { > $ratio = 3; > } >-if ($ratio == 0) { >+# Force to be a number >+$ratio += 0; >+if ($ratio <= 0) { > $ratio = 1; # prevent division by zero > } > >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6724
:
5201
|
5202
|
5203
|
5204
| 5210