Bugzilla – Attachment 52107 Details for
Bug 16649
OpenLibrarySearch.t fails when building packages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16649: Make OpenLibrarySearch test pass even if launches offline
Bug-16649-Make-OpenLibrarySearch-test-pass-even-if.patch (text/plain), 1.28 KB, created by
Galen Charlton
on 2016-06-07 01:54:26 UTC
(
hide
)
Description:
Bug 16649: Make OpenLibrarySearch test pass even if launches offline
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2016-06-07 01:54:26 UTC
Size:
1.28 KB
patch
obsolete
>From 93665427249274a5e143f6f4a8c47c35aa4dcc9e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sat, 4 Jun 2016 12:26:27 +0100 >Subject: [PATCH] Bug 16649: Make OpenLibrarySearch test pass even if launches > offline > >Test plan: > prove t/OpenLibrarySearch.t >should return green even if you are offline > >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> >Signed-off-by: Galen Charlton <gmcharlt@gmail.com> >--- > t/OpenLibrarySearch.t | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/t/OpenLibrarySearch.t b/t/OpenLibrarySearch.t >index 8084453..b0865e6 100644 >--- a/t/OpenLibrarySearch.t >+++ b/t/OpenLibrarySearch.t >@@ -22,7 +22,11 @@ use Test::More tests => 1; > use LWP::Simple; > use JSON; > my $content = get("https://openlibrary.org/search.json?q=9780201038095"); >-my $data = from_json($content); >-my $numFound = $data->{numFound}; > >-ok( $numFound > 0, "The openlibrary ws should return at least 1 result" ); >+SKIP: { >+ skip "json has not been retrieved from openlibrary.org", 1 unless defined $content; >+ my $data = from_json($content); >+ my $numFound = $data->{numFound}; >+ >+ ok( $numFound > 0, "The openlibrary ws should return at least 1 result" ); >+} >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16649
:
52043
|
52068
|
52071
| 52107