Bugzilla – Attachment 52124 Details for
Bug 16668
Fix t/Ris.t (follow-up for 16442)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16668: Fix t/Ris.t tests
Bug-16668-Fix-tRist-tests.patch (text/plain), 1.56 KB, created by
Marcel de Rooy
on 2016-06-07 12:12:29 UTC
(
hide
)
Description:
Bug 16668: Fix t/Ris.t tests
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-06-07 12:12:29 UTC
Size:
1.56 KB
patch
obsolete
>From 0c0f15a1d72ca937bc0f553a78d6694a39634c37 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 7 Jun 2016 12:29:33 +0100 >Subject: [PATCH] Bug 16668: Fix t/Ris.t tests >Content-Type: text/plain; charset=utf-8 > >Caused by bug 16442. >Now we need to mock the marcflavour pref > >Test plan: > prove t/Ris.t >should return green > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Ris.pm | 2 ++ > t/Ris.t | 8 ++++---- > 2 files changed, 6 insertions(+), 4 deletions(-) > >diff --git a/C4/Ris.pm b/C4/Ris.pm >index 2303fc2..0932cbf 100644 >--- a/C4/Ris.pm >+++ b/C4/Ris.pm >@@ -558,6 +558,7 @@ $clean_subtitle ||= q{}; > ## be written and designated. The field is free-form and resistant > ## to all parsing efforts, so this information is lost on me > } >+ return; > } > > ##******************************************************************** >@@ -590,6 +591,7 @@ sub print_stitle { > } > } > } >+ return; > } > > ##******************************************************************** >diff --git a/t/Ris.t b/t/Ris.t >index 0840e2c..c11b1f5 100755 >--- a/t/Ris.t >+++ b/t/Ris.t >@@ -3,15 +3,15 @@ > # This Koha test module is a stub! > # Add more tests here!!! > >-use strict; >-use warnings; >+use Modern::Perl; > >+use t::lib::Mocks; > use Test::More tests => 4; > > BEGIN { >- use_ok('C4::Ris'); >+ use_ok('C4::Ris'); > } >- >+t::lib::Mocks::mock_preference('marcflavour', 'MARC21'); > is(C4::Ris::print_typetag(),undef,'test printing typetag'); > > is(C4::Ris::print_title(),undef, 'test printing title when print_title is nil'); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16668
:
52064
|
52065
|
52123
| 52124