Bugzilla – Attachment 52151 Details for
Bug 15905
Remove use of makepayment
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15905 - Remove use of makepayment
Bug-15905---Remove-use-of-makepayment.patch (text/plain), 2.07 KB, created by
Kyle M Hall (khall)
on 2016-06-07 15:12:41 UTC
(
hide
)
Description:
Bug 15905 - Remove use of makepayment
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-06-07 15:12:41 UTC
Size:
2.07 KB
patch
obsolete
>From 22427326ffaf1f15cca4169d1cae29a6e74e1885 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 24 Feb 2016 16:11:26 +0000 >Subject: [PATCH] Bug 15905 - Remove use of makepayment > >Test Plan: >1) Apply these patches >2) prove t/db_dependent/Accounts.t >3) 'git grep makepayment' should return no results >--- > C4/Accounts.pm | 30 ------------------------------ > 1 file changed, 30 deletions(-) > >diff --git a/C4/Accounts.pm b/C4/Accounts.pm >index 682e59b..c91a6dd 100644 >--- a/C4/Accounts.pm >+++ b/C4/Accounts.pm >@@ -35,7 +35,6 @@ BEGIN { > require Exporter; > @ISA = qw(Exporter); > @EXPORT = qw( >- &makepayment > &manualinvoice > &getnextacctno > &getcharges >@@ -67,33 +66,6 @@ patron. > > =head1 FUNCTIONS > >-=head2 makepayment >- >- &makepayment($accountlines_id, $borrowernumber, $acctnumber, $amount, $branchcode); >- >-Records the fact that a patron has paid off the entire amount he or >-she owes. >- >-C<$borrowernumber> is the patron's borrower number. C<$acctnumber> is >-the account that was credited. C<$amount> is the amount paid (this is >-only used to record the payment. It is assumed to be equal to the >-amount owed). C<$branchcode> is the code of the branch where payment >-was made. >- >-=cut >- >-#' >-# FIXME - I'm not at all sure about the above, because I don't >-# understand what the acct* tables in the Koha database are for. >-sub makepayment { >- my ( $accountlines_id, $borrowernumber, $accountno, $amount, $user, $branch, $payment_note ) = @_; >- >- my $line = Koha::Account::Lines->find( $accountlines_id ); >- >- return Koha::Account->new( { patron_id => $borrowernumber } ) >- ->pay( { lines => [ $line ], amount => $amount, library_id => $branch, note => $payment_note } ); >-} >- > =head2 getnextacctno > > $nextacct = &getnextacctno($borrowernumber); >@@ -420,8 +392,6 @@ sub recordpayment_selectaccts { > ); > } > >-# makepayment needs to be fixed to handle partials till then this separate subroutine >-# fills in > sub makepartialpayment { > my ( $accountlines_id, $borrowernumber, $accountno, $amount, $user, $branch, $payment_note ) = @_; > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15905
:
48350
|
48351
|
52136
|
52150
|
52151
|
58821
|
58822
|
58831
|
58832
|
58841
|
58842
|
58843