Bugzilla – Attachment 52235 Details for
Bug 16613
MARC 09X Field Help Links are Broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16613: fix MARC 09X help links
Bug-16613-fix-MARC-09X-help-links.patch (text/plain), 1.80 KB, created by
Jonathan Druart
on 2016-06-10 14:47:24 UTC
(
hide
)
Description:
Bug 16613: fix MARC 09X help links
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-06-10 14:47:24 UTC
Size:
1.80 KB
patch
obsolete
>From caddf8715a26808b23f6855bbc19b7661af6576f Mon Sep 17 00:00:00 2001 >From: phette23 <phette23@gmail.com> >Date: Fri, 27 May 2016 10:13:14 -0700 >Subject: [PATCH] Bug 16613: fix MARC 09X help links > >The 09X MARC fields, such as 099 local call number or 090 >locally-assigned Library of Congress call number, all point to >non-existent pages on the LC website, e.g. >http://www.loc.gov/marc/bibliographic/bd090.html > >Test plan: >- enter the advanced cataloging editor >- begin to input any MARC tag of form 09X >- click the help link at the bottom of the browser window >=> Without this patch, taken to a URL of form `'http://www.loc.gov/marc/bibliographic/bd' + > tag + '.html'` which is broken because the only documentation for > these tags is at https://www.loc.gov/marc/bibliographic/bd09x.html >=> With this patch applied, the link is correct > >Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >index 87f5360..2f2a1c2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >@@ -163,6 +163,8 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > [% IF ( marcflavour == 'MARC21' ) %] > if ( tag == '000' ) { > return "http://www.loc.gov/marc/bibliographic/bdleader.html"; >+ } else if ( tag >= '090' && tag < '100' ) { >+ return "http://www.loc.gov/marc/bibliographic/bd09x.html"; > } else if ( tag < '900' ) { > return "http://www.loc.gov/marc/bibliographic/bd" + tag + ".html"; > } else { >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16613
:
51885
|
51889
|
52235
|
52237