Bugzilla – Attachment 52236 Details for
Bug 16570
All checked-in items are said to be part of a rotating collection
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16570: Do not tell all checked-in items are part of a rotating collection
Bug-16570-Do-not-tell-all-checked-in-items-are-par.patch (text/plain), 1.96 KB, created by
Nick Clemens (kidclamp)
on 2016-06-10 14:47:36 UTC
(
hide
)
Description:
Bug 16570: Do not tell all checked-in items are part of a rotating collection
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2016-06-10 14:47:36 UTC
Size:
1.96 KB
patch
obsolete
>From 5a5abf655776440d3470f1c75b08e1bc993110e9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 24 May 2016 19:57:16 +0100 >Subject: [PATCH] Bug 16570: Do not tell all checked-in items are part of a > rotating collection >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >When an item is checked-in a message will tell you it's part of a >rotating collection, even if it's not true. > >Test plan: >Make sure the message appears only when needed. > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > circ/returns.pl | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index 3804543..c91d784 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -642,16 +642,18 @@ $template->param( > > $itemnumber = GetItemnumberFromBarcode( $barcode ); > if ( $itemnumber ) { >- my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber ); >- $holdingBranch //= ''; >- $collectionBranch //= $returnbranch; >- if ( ! ( $holdingBranch eq $collectionBranch ) ) { >- $template->param( >- collectionItemNeedsTransferred => 1, >- collectionBranchName => GetBranchName($collectionBranch), >- collectionBranch => $collectionBranch, >- itemnumber => $itemnumber, >- ); >+ my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber ); >+ if ( $holdingBranch and $collectionBranch ) { >+ $holdingBranch //= ''; >+ $collectionBranch //= $returnbranch; >+ if ( ! ( $holdingBranch eq $collectionBranch ) ) { >+ $template->param( >+ collectionItemNeedsTransferred => 1, >+ collectionBranchName => GetBranchName($collectionBranch), >+ collectionBranch => $collectionBranch, >+ itemnumber => $itemnumber, >+ ); >+ } > } > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16570
:
51747
|
51749
| 52236