Bugzilla – Attachment 52244 Details for
Bug 16589
Quote of the day: Fix upload with csv files associated to LibreOffice Calc
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16589 - Quote of the day: Fix upload with csv files associated to LibreOffice Calc
Bug-16589---Quote-of-the-day-Fix-upload-with-csv-f.patch (text/plain), 1.90 KB, created by
Jonathan Druart
on 2016-06-10 15:10:35 UTC
(
hide
)
Description:
Bug 16589 - Quote of the day: Fix upload with csv files associated to LibreOffice Calc
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-06-10 15:10:35 UTC
Size:
1.90 KB
patch
obsolete
>From c6c83eecab28e7b7eb1185f52421d37dff35443f Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Sat, 28 May 2016 09:44:40 +0200 >Subject: [PATCH] Bug 16589 - Quote of the day: Fix upload with csv files > associated to LibreOffice Calc >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To reproduce: >- Install LibreOffice and make sure that csv files are associated to Calc > (Note: tested with Firefox 46.0.1 on Windows 8) >- Go to Home > Tools > Quote editor > Quote uploader >- Try to upload a valid CSV (e.g. Example from Bug 15684) >Result: File can not be uploaded > (Incorrect filetype: application/vnd.sun.xml.calc) >To test: >- Apply patch >- Try to upload again >Expected result: Quotes are imported. > >Signed-off-by: Frédéric Demians <f.demians@tamil.fr> > Can't reproduce on a Mac but get it fails on a Windows Box: fixed with this > patch. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Can't recreate on debian but the fix looks safe. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt >index f98d6dd..cf34371 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt >@@ -238,7 +238,7 @@ > var fileType = evt.target.files[0].type || 'unknown'; > var fileSizeInK = Math.round(evt.target.files[0].size/1024); > >- if (!fileType.match(/comma-separated-values|csv|excel/i)) { >+ if (!fileType.match(/comma-separated-values|csv|excel|calc/i)) { > alert(_("Uploads limited to csv. Incorrect filetype: %s").format(fileType)); > parent.location='quotes-upload.pl'; > return; >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16589
:
51892
|
51894
| 52244 |
53129