Bugzilla – Attachment 52291 Details for
Bug 14048
Change RefundLostItemFeeOnReturn to be branch specific
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14048: [QA Followup]
Bug-14048-QA-Followup.patch (text/plain), 2.61 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-06-12 12:52:19 UTC
(
hide
)
Description:
Bug 14048: [QA Followup]
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-06-12 12:52:19 UTC
Size:
2.61 KB
patch
obsolete
>From 3da60ba2a23af78558b95d922b1a1d401daed937 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 9 Jun 2016 16:48:07 +0000 >Subject: [PATCH] Bug 14048: [QA Followup] > >--- > C4/Circulation.pm | 35 ++++++++++++++++++++++------------- > 1 file changed, 22 insertions(+), 13 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index a1dc440..603589e 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1438,13 +1438,18 @@ sub AddIssue { > > ## If item was lost, it has now been found, reverse any list item charges if necessary. > if ( $item->{'itemlost'} ) { >- if ( Koha::RefundLostItemFeeRules->should_refund( >- current_branch => C4::Context->userenv->{ branch }, >- patron_branch => $borrower->{ branchcode }, >- item_home_branch => $item->{ homebranch }, >- item_holding_branch => $item->{ holdingbranch } >- ) ) { >- _FixAccountForLostAndReturned( $item->{'itemnumber'}, undef, $item->{'barcode'} ); >+ if ( >+ Koha::RefundLostItemFeeRules->should_refund( >+ { >+ current_branch => C4::Context->userenv->{branch}, >+ item_home_branch => $item->{homebranch}, >+ item_holding_branch => $item->{holdingbranch} >+ } >+ ) >+ ) >+ { >+ _FixAccountForLostAndReturned( $item->{'itemnumber'}, undef, >+ $item->{'barcode'} ); > } > } > >@@ -2117,12 +2122,16 @@ sub AddReturn { > $messages->{'WasLost'} = 1; > > if ( $item->{'itemlost'} ) { >- if ( Koha::RefundLostItemFeeRules->should_refund( >- current_branch => C4::Context->userenv->{ branch }, >- patron_branch => $borrower->{ branchcode }, >- item_home_branch => $item->{ homebranch }, >- item_holding_branch => $item->{ holdingbranch } >- ) ) { >+ if ( >+ Koha::RefundLostItemFeeRules->should_refund( >+ { >+ current_branch => C4::Context->userenv->{branch}, >+ item_home_branch => $item->{homebranch}, >+ item_holding_branch => $item->{holdingbranch} >+ } >+ ) >+ ) >+ { > _FixAccountForLostAndReturned( $item->{'itemnumber'}, $borrowernumber, $barcode ); > $messages->{'LostItemFeeRefunded'} = 1; > } >-- >2.8.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14048
:
52016
|
52017
|
52018
|
52019
|
52020
|
52169
|
52170
|
52202
|
52203
|
52286
|
52287
|
52288
|
52289
|
52290
|
52291
|
52292
|
52293
|
52306
|
52444
|
52445
|
52446
|
52447
|
52448
|
52449
|
52450
|
52451
|
52482
|
52658
|
52659
|
52660
|
52661
|
52662
|
52663
|
52664
|
52665
|
52666
|
52667
|
52668
|
52748
|
52749
|
52750
|
52751
|
52752
|
52753
|
52754
|
52755
|
52756
|
52757
|
52835
|
52836
|
52837
|
52838
|
52839
|
52840
|
52841
|
52842
|
52843
|
52844
|
52876
|
52883
|
52894
|
53017
|
53018
|
53019
|
53020
|
53021
|
53022
|
53023
|
53024
|
53025
|
53026
|
53027
|
53028
|
53029