Attachment 52360 Details for Bug 12748 – Bug 12748: findSerialByStatus has been renamed with findSerialsByStatus

[patch] Bug 12748: findSerialByStatus has been renamed with findSerialsByStatus

Bug-12748-findSerialByStatus-has-been-renamed-with.patch (text/plain), 1.66 KB, created by Jonathan Druart on 2016-06-14 09:53:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-06-14 09:53:56 UTC

Size: 1.66 KB

patch

obsolete

>From fa9949c9d1a33571e9dbd3dec6f9c2d0dde4daa6 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 14 Jun 2016 10:49:41 +0100
>Subject: [PATCH] Bug 12748: findSerialByStatus has been renamed with
> findSerialsByStatus
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> C4/Serials.pm            | 2 +-
> t/db_dependent/Serials.t | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Serials.pm b/C4/Serials.pm
>index 5cbd7df..39e0e96 100644
>--- a/C4/Serials.pm
>+++ b/C4/Serials.pm
>@@ -2700,7 +2700,7 @@ sub _can_do_on_subscription {
> 
> =head2 findSerialsByStatus
> 
>-    @serials = findSerialByStatus($status, $subscriptionid);
>+    @serials = findSerialsByStatus($status, $subscriptionid);
> 
>     Returns an array of serials matching a given status and subscription id.
> 
>diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t
>index e848280..b053681 100755
>--- a/t/db_dependent/Serials.t
>+++ b/t/db_dependent/Serials.t
>@@ -221,7 +221,7 @@ for my $status ( @statuses ) {
> }
> # Here we have 15 serials with statuses : 2*2 + 5*3 + 2*4 + 1*41 + 1*42 + 1*43 + 1*44 + 1*5 + 1*1
> my @serialsByStatus = C4::Serials::findSerialsByStatus(2,$subscriptionid);
>-is(@serialsByStatus,2,"findSerialByStatus returns all serials with chosen status");
>+is(@serialsByStatus,2,"findSerialsByStatus returns all serials with chosen status");
> ( $total_issues, @serials ) = C4::Serials::GetSerials( $subscriptionid );
> is( $total_issues, @statuses + 1, "GetSerials returns total_issues" );
> my @arrived_missing = map { my $status = $_->{status}; ( grep { /^$status$/ } qw( 2 4 41 42 43 44 5 ) ) ? $_ : () } @serials;
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 12748: 41228 | 41230 | 41371 | 41451 | 44533 | 46091 | 47770 | 47771 | 47773 | 47774 | 47775 | 47776 | 52356 | 52357 | 52358 | 52359 | 52360