Attachment 52363 Details for Bug 16717 – Bug 16717: Remove hardcoded category from Holds.t

[patch] Bug 16717: Remove hardcoded category from Holds.t

Bug-16717-Remove-hardcoded-category-from-Holdst.patch (text/plain), 1.64 KB, created by Jonathan Druart on 2016-06-14 10:20:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-06-14 10:20:47 UTC

Size: 1.64 KB

patch

obsolete

>From 144cd4817251a82fcbf68b1a0b08015df02521c6 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 27 May 2016 13:48:10 +0200
>Subject: [PATCH] Bug 16717: Remove hardcoded category from Holds.t
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>There is actually no need to use the hardcoded patron category S in
>this test.
>
>Test plan:
>Run t/db_dependent/Holds.t.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Test passes OK
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> t/db_dependent/Holds.t | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t
>index 7e490e3..b368481 100755
>--- a/t/db_dependent/Holds.t
>+++ b/t/db_dependent/Holds.t
>@@ -34,11 +34,7 @@ my $dbh     = C4::Context->dbh;
> my $branch_1 = $builder->build({ source => 'Branch' })->{ branchcode };
> my $branch_2 = $builder->build({ source => 'Branch' })->{ branchcode };
> 
>-# This test assumes we have a category S. This statement helps.
>-$builder->build({
>-    source => 'Category',
>-    value  => { categorycode => 'S', category_type => 'S' },
>-});
>+my $category = $builder->build({ source => 'Category' })->{categorycode};
> 
> my $borrowers_count = 5;
> 
>@@ -64,7 +60,7 @@ foreach (1..$borrowers_count) {
>     my $borrowernumber = AddMember(
>         firstname =>  'my firstname',
>         surname => 'my surname ' . $_,
>-        categorycode => 'S',
>+        categorycode => $category,
>         branchcode => $branch_1,
>     );
>     push @borrowernumbers, $borrowernumber;
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 16717: 52301 | 52304 | 52363 | 52364