Attachment 52381 Details for Bug 16736 – Bug 16736 - Keep branch filter when changing suggestion

[patch] Bug 16736 - Keep branch filter when changing suggestion

Bug-16736---Keep-branch-filter-when-changing-sugge.patch (text/plain), 1.43 KB, created by Fridolin Somers on 2016-06-14 15:09:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2016-06-14 15:09:30 UTC

Size: 1.43 KB

patch

obsolete

>From 05c0223ed272b13fbab3d3444e23184d54ca9a87 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Tue, 14 Jun 2016 17:05:58 +0200
>Subject: [PATCH] Bug 16736 - Keep branch filter when changing suggestion
>
>When changing suggestion, the selected tab is kept.
>The same should be done with the selected branch.
>
>Test plan:
>- Go to suggestions table : /cgi-bin/koha/suggestion/suggestion.pl
>- Select a branch in Acquisition information > For
>- Select a pending suggestion
>- Change status as accepted
>- Click on Submit
>=> without patch, the table is no longer filtered by branch
>=> with patch, the table is filtered by branch
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index fd4f474..cbe3e44 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -637,7 +637,7 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o
>         </div>
>     </div>
> 
>-
>+    <input type="hidden" name="branchcode" value="[% branchfilter %]" />
>     <input type="hidden" name="tabcode" value="[% suggestion.suggestiontype %]" />
>     <input type="hidden" name="op" value="change" />
> </fieldset>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 16736: 52381 | 52395 | 52536