Bugzilla – Attachment 52425 Details for
Bug 14504
Add command-line script to batch delete items based on data in items table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14504: (QA followup) fix test transaction, book_on_loan
Bug-14504-QA-followup-fix-test-transaction-bookonl.patch (text/plain), 1.43 KB, created by
Barton Chittenden
on 2016-06-15 13:58:32 UTC
(
hide
)
Description:
Bug 14504: (QA followup) fix test transaction, book_on_loan
Filename:
MIME Type:
Creator:
Barton Chittenden
Created:
2016-06-15 13:58:32 UTC
Size:
1.43 KB
patch
obsolete
>From cbda6f0df622f8f70ab830e857314eb507062945 Mon Sep 17 00:00:00 2001 >From: Barton Chittenden <barton@bywatersolutions.com> >Date: Wed, 25 May 2016 07:12:43 -0700 >Subject: [PATCH] Bug 14504: (QA followup) fix test transaction, book_on_loan > >--- > misc/cronjobs/delete_items.pl | 2 +- > t/db_dependent/Circulation/IsItemIssued.t | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/misc/cronjobs/delete_items.pl b/misc/cronjobs/delete_items.pl >index f3d3de6..0e9e8d1 100755 >--- a/misc/cronjobs/delete_items.pl >+++ b/misc/cronjobs/delete_items.pl >@@ -58,7 +58,7 @@ $GLOBAL->{sth}->{target_items}->execute(); > DELITEM: while ( my $item = $GLOBAL->{sth}->{target_items}->fetchrow_hashref() ) { > > my $status = C4::Items::ItemSafeToDelete( $item->{itemnumber}, $item->{biblionumber} ); >- if( $status == 1 ) { >+ if( $status eq '1' ) { > C4::Items::DelItemCheck( $item->{itemnumber}, $item->{biblionumber} ); > verbose "Deleting '$item->{itemnumber}'"; > } else { >diff --git a/t/db_dependent/Circulation/IsItemIssued.t b/t/db_dependent/Circulation/IsItemIssued.t >index 907a3cf..bafc405 100644 >--- a/t/db_dependent/Circulation/IsItemIssued.t >+++ b/t/db_dependent/Circulation/IsItemIssued.t >@@ -58,6 +58,8 @@ is( > 'item that is not on loan can be deleted', > ); > >+$schema->storage->txn_rollback; >+ > # C4::Context->userenv > sub Mock_userenv { > return { branch => $library->{branchcode} }; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14504
:
40830
|
42978
|
43445
|
43533
|
43788
|
43789
|
44013
|
44149
|
45789
|
49648
|
49649
|
49650
|
49651
|
49652
|
49653
|
52425
|
53224
|
53225
|
54514
|
54515
|
54516
|
54517
|
54518
|
54519
|
54520
|
54521
|
54522
|
54525
|
54530
|
54531
|
54691
|
54692
|
54693
|
54694
|
54695
|
54696
|
54697
|
54698
|
54699
|
54700
|
54701
|
54702
|
54703