Bugzilla – Attachment 52537 Details for
Bug 16737
Error when deleting EDIFACT message
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 16737 - Error when deleting EDIFACT message
PASSED-QA-Bug-16737---Error-when-deleting-EDIFACT-.patch (text/plain), 1.26 KB, created by
Katrin Fischer
on 2016-06-19 11:51:47 UTC
(
hide
)
Description:
[PASSED QA] Bug 16737 - Error when deleting EDIFACT message
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-06-19 11:51:47 UTC
Size:
1.26 KB
patch
obsolete
>From 548b0982daf703541a9e5ad758fb29fa2d8051ad Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 14 Jun 2016 18:05:53 +0000 >Subject: [PATCH] [PASSED QA] Bug 16737 - Error when deleting EDIFACT message > >If you try to delete an EDIFACT message it triggers an error: > >Can't use string ("2") as a subroutine ref while "strict refs" in use at >/acqui/edifactmsgs.pl line 43. > >Test Plan: >1) Attempt to delete an EDIFACT message >2) Note the error >3) Apply this patch >4) Attempt to delete an EDIFACT message again >5) Note it succeeds > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > acqui/edifactmsgs.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/edifactmsgs.pl b/acqui/edifactmsgs.pl >index 0498b3d..2a9a7af 100755 >--- a/acqui/edifactmsgs.pl >+++ b/acqui/edifactmsgs.pl >@@ -40,7 +40,7 @@ my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user( > my $schema = Koha::Database->new()->schema(); > my $cmd = $q->param('op'); > if ( $cmd && $cmd == 'delete' ) { >- my $id = $q->param->('message_id'); >+ my $id = $q->param('message_id'); > my $msg = $schema->resultset('EdifactMessage')->find($id); > $msg->deleted(1); > $msg->update; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16737
:
52404
|
52405
| 52537