Bugzilla – Attachment 52540 Details for
Bug 12598
New misc/import_borrowers.pl command line tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12598: catch warnings raised by import_patrons in tests
Bug-12598-catch-warnings-raised-by-importpatrons-i.patch (text/plain), 1.94 KB, created by
Jonathan Druart
on 2016-06-19 12:03:56 UTC
(
hide
)
Description:
Bug 12598: catch warnings raised by import_patrons in tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-06-19 12:03:56 UTC
Size:
1.94 KB
patch
obsolete
>From 1ccde52ebb6c0c9f0c5cd02629d2e684135e5657 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sun, 19 Jun 2016 13:02:52 +0100 >Subject: [PATCH] Bug 12598: catch warnings raised by import_patrons in tests > >--- > t/db_dependent/Koha/Patrons/Import.t | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Koha/Patrons/Import.t b/t/db_dependent/Koha/Patrons/Import.t >index abcca11..3c46ce2 100644 >--- a/t/db_dependent/Koha/Patrons/Import.t >+++ b/t/db_dependent/Koha/Patrons/Import.t >@@ -18,7 +18,8 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; >-use Test::More tests => 122; >+use Test::More tests => 124; >+use Test::Warn; > > # To be replaced by t::lib::Mock > use Test::MockModule; >@@ -63,14 +64,20 @@ subtest 'test_attributes' => sub { > > # Tests for Koha::Patrons::Import::import_patrons() > # Given ... nothing much. When ... Then ... >-my $result = $patrons_import->import_patrons(undef); >+my $result; >+warning_is { $result = $patrons_import->import_patrons(undef) } >+ { carped => 'No file handle passed in!' }, >+ " Koha::Patrons::Import->import_patrons carps if no file handle is passed"; > is($result, undef, 'Got the expected undef from import_patrons with nothing much'); > > # Given ... some params but no file handle. > my $params_0 = { some_stuff => 'random stuff', }; > > # When ... Then ... >-my $result_0 = $patrons_import->import_patrons($params_0); >+my $result_0; >+warning_is { $result_0 = $patrons_import->import_patrons($params_0) } >+ { carped => 'No file handle passed in!' }, >+ " Koha::Patrons::Import->import_patrons carps if no file handle is passed"; > is($result_0, undef, 'Got the expected undef from import_patrons with no file handle'); > > # Given ... a file handle to file with headers only. >@@ -622,4 +629,4 @@ sub make_csv { > return $filename; > } > >-1; >\ No newline at end of file >+1; >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12598
:
29807
|
29808
|
29809
|
29939
|
30755
|
30780
|
35557
|
35558
|
35559
|
35560
|
35848
|
35849
|
35850
|
35851
|
35964
|
36684
|
36685
|
36687
|
36688
|
36690
|
36692
|
36693
|
36694
|
36695
|
36696
|
39124
|
39125
|
39126
|
39127
|
39128
|
41790
|
41791
|
41792
|
41793
|
41794
|
44065
|
44066
|
44067
|
44068
|
44069
|
48753
|
48754
|
48755
|
48756
|
48757
|
50693
|
50694
|
50695
|
50696
|
50697
|
50698
|
50699
|
50700
|
50704
|
51122
|
51357
|
51358
|
51359
|
51360
|
51361
|
51362
|
51363
|
51364
|
51365
|
51366
|
51367
|
51368
|
51369
|
51370
|
51371
|
51372
|
52323
|
52324
|
52325
|
52326
|
52327
|
52328
|
52329
|
52330
|
52331
|
52332
|
52333
|
52540
|
64437
|
64438
|
64855
|
65214
|
65215
|
65216
|
65217
|
65218
|
65819
|
65820
|
65821
|
65822
|
65823
|
65824
|
66353
|
66354
|
66355
|
66356
|
66357
|
66358
|
66359
|
66575
|
66576
|
66577
|
66578
|
66579
|
66580
|
66581
|
66582
|
67276
|
67277
|
70265
|
70266
|
71755
|
71756
|
71757
|
71758
|
71759
|
71760
|
71761
|
71762
|
71763
|
71764
|
71765
|
71766