Bugzilla – Attachment 52712 Details for
Bug 16770
Remove wrong uses of Memoize::Memcached
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16770: Remove wrong caching of 3 subroutines in C4::Lancuages
Bug-16770-Remove-wrong-caching-of-3-subroutines-in.patch (text/plain), 1.45 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-06-23 13:09:11 UTC
(
hide
)
Description:
Bug 16770: Remove wrong caching of 3 subroutines in C4::Lancuages
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-06-23 13:09:11 UTC
Size:
1.45 KB
patch
obsolete
>From 30317823f4482e7a20d7739f30d78d35c80d2f12 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sat, 18 Jun 2016 15:21:28 +0100 >Subject: [PATCH] Bug 16770: Remove wrong caching of 3 subroutines in > C4::Lancuages > >ooking at this code, you might think these subroutines are cached, but >actually they are not. > >The eval surrounding the code hides a bug, if you remove it, you will >get: > Invalid memcached argument (expected a hash) > >Test plan: >Do not apply this patch and confirm that the code does not work > >Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Languages.pm | 11 ----------- > 1 file changed, 11 deletions(-) > >diff --git a/C4/Languages.pm b/C4/Languages.pm >index 38e87b6..5e4dabd 100644 >--- a/C4/Languages.pm >+++ b/C4/Languages.pm >@@ -29,17 +29,6 @@ use C4::Context; > use Koha::Cache::Memory::Lite; > use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $DEBUG); > >-eval { >- if (C4::Context->ismemcached) { >- require Memoize::Memcached; >- import Memoize::Memcached qw(memoize_memcached); >- >- memoize_memcached('getTranslatedLanguages', memcached => C4::Context->memcached); >- memoize_memcached('getFrameworkLanguages' , memcached => C4::Context->memcached); >- memoize_memcached('getAllLanguages', memcached => C4::Context->memcached); >- } >-}; >- > BEGIN { > require Exporter; > @ISA = qw(Exporter); >-- >2.9.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16770
:
52513
|
52514
|
52515
|
52555
|
52556
|
52557
|
52640
|
52678
| 52712 |
52713
|
52714