Bugzilla – Attachment 52737 Details for
Bug 14790
Link to OPAC view from within subscriptions, search and item editor
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14790 [QA Followup] - Don't show links unless OPACBaseURL is set
Bug-14790-QA-Followup---Dont-show-links-unless-OPA.patch (text/plain), 4.71 KB, created by
Kyle M Hall (khall)
on 2016-06-23 14:46:30 UTC
(
hide
)
Description:
Bug 14790 [QA Followup] - Don't show links unless OPACBaseURL is set
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-06-23 14:46:30 UTC
Size:
4.71 KB
patch
obsolete
>From 01e97f66d490889a08a97fa16a9e96bb738ce38f Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 23 Jun 2016 14:45:34 +0000 >Subject: [PATCH] Bug 14790 [QA Followup] - Don't show links unless OPACBaseURL > is set > >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 10 +++++++--- > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 4 +++- > .../prog/en/modules/serials/subscription-detail.tt | 10 ++++++---- > 3 files changed, 16 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 2d86c12..1fa8259 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -565,9 +565,13 @@ var holdForPatron = function () { > [% IF ( CAN_user_editcatalogue_edit_items ) %] > | <a href="/cgi-bin/koha/cataloguing/additem.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">Edit items</a> > [% END %] >- <span class="view-in-opac"> >- | <a href="[% Koha.Preference('OPACBaseURL') %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]" target="_blank">OPAC view</a> >- </span> >+ >+ [% IF ( OPACBaseURL ) %] >+ <span class="view-in-opac"> >+ | <a href="[% Koha.Preference('OPACBaseURL') %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]" target="_blank">OPAC view</a> >+ </span> >+ [% END %] >+ > </p> > </td> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >index 0a9ef7f..75b5ea8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >@@ -208,7 +208,9 @@ function confirm_deletion() { > <li><a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delitem&biblionumber=[% biblionumber %]&itemnumber=[% item_loo.itemnumber %]&searchid=[% searchid %]" onclick="return confirm_deletion();">Delete</a></li> > [% END %] > [% END %] >- <li class="view-in-opac"><a target="_blank" href="[% Koha.Preference('OPACBaseURL') %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber %]">OPAC view</a></li> >+ [% IF ( OPACBaseURL ) %] >+ <li class="view-in-opac"><a target="_blank" href="[% Koha.Preference('OPACBaseURL') %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber %]">OPAC view</a></li> >+ [% END %] > </ul> > </div> > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >index c8daa2d..157c135 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >@@ -89,10 +89,12 @@ $(document).ready(function() { > <li><span class="label">Librarian identity:</span> [% librarian %]</li> > <li><span class="label">Vendor:</span> <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% aqbooksellerid %]">[% aqbooksellername %]</a></li> > <li><span class="label">Biblio:</span> <a href="/cgi-bin/koha/catalogue/[% default_bib_view %].pl?biblionumber=[% bibnum %]">[% bibliotitle %]</a> <i>([% bibnum %])</i></li> >- <li> >- <span class="label">OPAC view:</span> >- <a id="view-subscription-in-opac" target="_blank" href="[% Koha.Preference('OPACBaseURL') %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber %]">Open in new window.</a> >- </li> >+ [% IF ( OPACBaseURL ) %] >+ <li> >+ <span class="label">OPAC view:</span> >+ <a id="view-subscription-in-opac" target="_blank" href="[% Koha.Preference('OPACBaseURL') %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber %]">Open in new window.</a> >+ </li> >+ [% END %] > [% IF ( branchcode ) %]<li><span class="label">Library:</span> [% Branches.GetName( branchcode ) %]</li>[% END %] > [% IF ( serialsadditems ) %] > <li><span class="label">Items:</span> Serial receipt creates an item record.</li> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14790
:
52427
|
52428
|
52429
|
52430
|
52434
|
52435
|
52436
|
52437
|
52438
|
52439
|
52737
|
52890
|
52891
|
52892
|
52893