Attachment 52770 Details for Bug 16400 – Bug 16400 [Follow-up] Proposal to uniform the placement of submit buttons

[patch] Bug 16400 [Follow-up] Proposal to uniform the placement of submit buttons

Bug-16400-Follow-up-Proposal-to-uniform-the-placem.patch (text/plain), 1.90 KB, created by Nick Clemens (kidclamp) on 2016-06-23 21:34:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2016-06-23 21:34:06 UTC

Size: 1.90 KB

patch

obsolete

>From f83679f0c52f981cfa5f3f431007447e4f4b50c1 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 16 May 2016 14:01:34 -0400
>Subject: [PATCH] Bug 16400 [Follow-up] Proposal to uniform the placement of
> submit buttons
>
>This follow-up makes some corrections to the markup of the cancel
>button:
>
>- Use <a> instead of <button> to eliminate the need for an "onclick"
>  attribute.
>- Remove the "cancel" class which adds unwanted padding.
>- Correct the destination of the cancel button when cancelling during an
>  edit (should redirect to the patron detail page).
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 616c48a..17eeb5b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -183,12 +183,12 @@ $(document).ready(function() {
> [% UNLESS ( check_member ) %]
>     <button class="btn btn-small" id="saverecord" type="submit" name="save" onclick="return check_form_borrowers();"><i class="fa fa-save"></i> Save</button>
>     [% IF opadd %]
>-    <button class="btn btn-small cancel" onclick="/cgi-bin/koha/members/member.pl">
>+        <a class="btn btn-small" href="/cgi-bin/koha/members/member.pl">
>     [% ELSE %]
>-    <a class='btn btn-small cancel" onclick="/cgi-bin/koha/members/member.pl?borrowernumber=[% borrowernumber %]">
>+        <a class="btn btn-small" href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">
>     [% END %]
>         <i class="fa fa-times"></i> Cancel
>-    </button>
>+    </a>
> [% END %]
> </div>
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16400: 51043 | 51044 | 51144 | 51145 | 51449 | 51471 | 51517 | 51546 | 51547 | 51548 | 51549 | 51550 | 51551 | 51569 | 52765 | 52766 | 52767 | 52768 | 52769 | 52770