Bugzilla – Attachment 52809 Details for
Bug 16808
Serial claims: claiming via CSV export doesn't reload the page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16808 - Serial claims: claiming via CSV export doesn't reload the page
Bug-16808---Serial-claims-claiming-via-CSV-export-.patch (text/plain), 1.63 KB, created by
Kyle M Hall (khall)
on 2016-06-24 14:56:08 UTC
(
hide
)
Description:
Bug 16808 - Serial claims: claiming via CSV export doesn't reload the page
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-06-24 14:56:08 UTC
Size:
1.63 KB
patch
obsolete
>From 163d239a4779cc8e71cf84af4d27a3c665966ecc Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 24 Jun 2016 14:53:54 +0000 >Subject: [PATCH] Bug 16808 - Serial claims: claiming via CSV export doesn't > reload the page > >When using the CSV export for claiming serial issues, with bug 12178 the >claim counter is incremented and a claim date set, but this will only be >visible after reloading the page manually as the feature itself doesn't >reload the page. > >To avoid confusion and errors using this feature,, the page should >reload when the claims data is changed. > >Test Plan: >1) Claim some serials >2) Note the page does not reload, the status is not set to 'claimed' >3) Apply this patch >4) Claim some serials >5) Note the page reloads and verify that the status of the selected > serials are "claimed" >--- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >index 54a5cfb..197cd00 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >@@ -48,8 +48,11 @@ > url += '&serialid=' + selected[i].value; > } > url += '&csv_profile=' + $("#csv_profile_for_export option:selected").val(); >- // And redirecting to the CSV page >- location.href = url; >+ >+ // Open download link in new window, then reload this page >+ window.open(url); >+ location.reload(); >+ > return false; > }); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16808
:
52809
|
53855