Bugzilla – Attachment 52833 Details for
Bug 16807
Frameworks unordered in dropdown when adding/editing a biblio
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio
Bug-16807-Frameworks-unordered-in-dropdown-when-ad.patch (text/plain), 2.26 KB, created by
Kyle M Hall (khall)
on 2016-06-24 16:16:11 UTC
(
hide
)
Description:
Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-06-24 16:16:11 UTC
Size:
2.26 KB
patch
obsolete
>From 269fb5a22aa546958ed6abdfd02a9a68cdcef18a Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 24 Jun 2016 09:57:07 -0400 >Subject: [PATCH] Bug 16807: Frameworks unordered in dropdown when > adding/editing a biblio > >To test: >Start to add or edit a biblio >Open the dropdown to change framework >Notice the order >Refresh the page - notice the order changes >Apply patch >Order is alphabetical >Refresh the page >Order does not change > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as described > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > cataloguing/addbiblio.pl | 16 +--------------- > .../prog/en/modules/cataloguing/addbiblio.tt | 2 +- > 2 files changed, 2 insertions(+), 16 deletions(-) > >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index f0263ef..ef7b845 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -746,21 +746,7 @@ if ($frameworkcode eq 'FA'){ > } > > >-# Getting the list of all frameworks >-# get framework list >-my $frameworks = getframeworks; >-my @frameworkcodeloop; >-foreach my $thisframeworkcode ( keys %$frameworks ) { >- my %row = ( >- value => $thisframeworkcode, >- frameworktext => $frameworks->{$thisframeworkcode}->{'frameworktext'}, >- ); >- if ($frameworkcode eq $thisframeworkcode){ >- $row{'selected'} = 1; >- } >- push @frameworkcodeloop, \%row; >-} >-$template->param( frameworkcodeloop => \@frameworkcodeloop, >+$template->param( frameworkcodeloop => GetFrameworksLoop( $frameworkcode ) , > breedingid => $breedingid ); > > # ++ Global >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index a7f5300..0dcd73e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -500,7 +500,7 @@ function Changefwk(FwkList) { > [% ELSE %] > <i class="fa fa-fw"> </i> > [% END %] >- [% frameworkcodeloo.frameworktext %] >+ [% frameworkcodeloo.description %] > </a> > </li> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16807
:
52799
|
52808
|
52828
| 52833 |
52834