Bugzilla – Attachment 52884 Details for
Bug 16780
Specify due date always sets time as AM when using 12 hour time format
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16780 - Specify due date always sets time as AM when using 12 hour time format
Bug-16780---Specify-due-date-always-sets-time-as-A.patch (text/plain), 1.78 KB, created by
Claire Gravely
on 2016-06-26 20:24:31 UTC
(
hide
)
Description:
Bug 16780 - Specify due date always sets time as AM when using 12 hour time format
Filename:
MIME Type:
Creator:
Claire Gravely
Created:
2016-06-26 20:24:31 UTC
Size:
1.78 KB
patch
obsolete
>From 75cff71d7a221354bb89f8390b9ec057095c7bbb Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 24 Jun 2016 10:35:25 +0000 >Subject: [PATCH] Bug 16780 - Specify due date always sets time as AM when > using 12 hour time format > >This regression is occurs because the time format for the checkout >date/time widget is only meant to be given in 24 hour format. The time >due should not be converted to 12 hr time even if the library has 12 >hour set as their preferred time format. > >Test Plan: >1) Performat a backdated checkout with a date due that has a PM time >2) Note the date/time picker on the confirmition screen shows the time > in AM/PM >2) Note the time is not stored correctly >3) Apply this patch >4) Repeate step 1 >5) Note the confirmation date/time picker now show the time in 24hr > format >6) Note the time was stored correctly > >Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> >--- > circ/circulation.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index b2201cf..c1a86ba 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -162,7 +162,7 @@ for my $barcode ( @$barcodes ) { > > my $stickyduedate = $query->param('stickyduedate') || $session->param('stickyduedate'); > my $duedatespec = $query->param('duedatespec') || $session->param('stickyduedate'); >-$duedatespec = eval { output_pref( { dt => dt_from_string( $duedatespec ), dateformat => 'iso' }); } >+$duedatespec = eval { output_pref( { dt => dt_from_string( $duedatespec ), dateformat => 'iso', timeformat => '24hr' }); } > if ( $duedatespec ); > my $restoreduedatespec = $query->param('restoreduedatespec') || $session->param('stickyduedate') || $duedatespec; > if ( $restoreduedatespec && $restoreduedatespec eq "highholds_empty" ) { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16780
:
52781
|
52884
|
52896