Bugzilla – Attachment 52887 Details for
Bug 16671
Wrong itemtype picked in HoldsQueue.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16671: [QA Follow-up] Add new itemtype and remove bailout
Bug-16671-QA-Follow-up-Add-new-itemtype-and-remove.patch (text/plain), 1.47 KB, created by
Marcel de Rooy
on 2016-06-27 07:52:50 UTC
(
hide
)
Description:
Bug 16671: [QA Follow-up] Add new itemtype and remove bailout
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-06-27 07:52:50 UTC
Size:
1.47 KB
patch
obsolete
>From ab21a809f5a041bb449dc73d143cefcd991bcc98 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 27 Jun 2016 09:24:14 +0200 >Subject: [PATCH] Bug 16671: [QA Follow-up] Add new itemtype and remove > bailout >Content-Type: text/plain; charset=utf-8 > >No need to bail out, if we are using TestBuilder. >Somehow, this test passes with me if we add a new record, and if >we do not, it fails (using BK as the first itemtype with notforloan >is 0). > >Looking further, we should imo remove the Koha::ItemTypes searches >here and not depend on existing data. Just add some item types. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/HoldsQueue.t | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/t/db_dependent/HoldsQueue.t b/t/db_dependent/HoldsQueue.t >index 5b1f09e..5302b47 100755 >--- a/t/db_dependent/HoldsQueue.t >+++ b/t/db_dependent/HoldsQueue.t >@@ -61,8 +61,7 @@ my $borrower_branchcode = $borrower->{branchcode}; > my @branchcodes = ( $library1->{branchcode}, $library2->{branchcode}, $library3->{branchcode} ); > my @other_branches = ( $library2->{branchcode}, $library3->{branchcode} ); > my $least_cost_branch_code = pop @other_branches; >-my $itemtype = Koha::ItemTypes->search({ notforloan => 0 })->next->itemtype; >-$itemtype or BAIL_OUT("No adequate itemtype"); >+my $itemtype = $builder->build({ source => 'Itemtype', value => { notforloan => 0 } })->{itemtype}; > > #Set up the stage > # Sysprefs and cost matrix >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16671
:
52078
|
52096
|
52887
|
52888
|
52921
|
52922
|
52923