Bugzilla – Attachment 52951 Details for
Bug 16836
Document unused parameters of SearchAuthorities
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16836: Document unused parameters of SearchAuthorities
Bug-16836-Document-unused-parameters-of-SearchAuth.patch (text/plain), 1.57 KB, created by
Marcel de Rooy
on 2016-06-30 10:09:19 UTC
(
hide
)
Description:
Bug 16836: Document unused parameters of SearchAuthorities
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-06-30 10:09:19 UTC
Size:
1.57 KB
patch
obsolete
>From 86879a04bc4166111ea33e35c7ccb2912fb9883c Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 30 Jun 2016 11:57:18 +0200 >Subject: [PATCH] Bug 16836: Document unused parameters of SearchAuthorities >Content-Type: text/plain; charset=utf-8 > >Two parameters $and_or and $excluding are not used. > >Test plan: >Run t/db_dependent/Search.t >--- > C4/AuthoritiesMarc.pm | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > >diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm >index 4332c67..f836121 100644 >--- a/C4/AuthoritiesMarc.pm >+++ b/C4/AuthoritiesMarc.pm >@@ -98,17 +98,16 @@ sub GetAuthMARCFromKohaField { > > =head2 SearchAuthorities > >- (\@finalresult, $nbresults)= &SearchAuthorities($tags, $and_or, >- $excluding, $operator, $value, $offset,$length,$authtypecode, >- $sortby[, $skipmetadata]) >+ ( \@finalresult, $nbresults ) = &SearchAuthorities( >+ $tags, undef, undef, $operator, $value, $offset, $length, >+ $authtypecode, $sortby[, $skipmetadata] ) > > returns ref to array result and count of results returned > > =cut > > sub SearchAuthorities { >- my ($tags, $and_or, $excluding, $operator, $value, $offset,$length,$authtypecode,$sortby,$skipmetadata) = @_; >- # warn Dumper($tags, $and_or, $excluding, $operator, $value, $offset,$length,$authtypecode,$sortby); >+ my ( $tags, undef, undef, $operator, $value, $offset, $length, $authtypecode, $sortby, $skipmetadata) = @_; # NOTE: Parameter 2 (and_or) and 3 (excluding) were not used. > my $dbh=C4::Context->dbh; > $sortby="" unless $sortby; > my $query; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16836
: 52951