Attachment 53044 Details for Bug 15128 – Bug 15128: Revert Display all purchase suggestions whether or not suggestion was added

[patch] Bug 15128: Revert Display all purchase suggestions whether or not suggestion was added

Bug-15128-Revert-Display-all-purchase-suggestions-.patch (text/plain), 1.80 KB, created by Jonathan Druart on 2016-07-01 16:04:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-07-01 16:04:20 UTC

Size: 1.80 KB

patch

obsolete

>From 1d8d527790a407d9de49461350fb9b6299b37ec2 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 1 Jul 2016 16:55:39 +0100
>Subject: [PATCH] Bug 15128: Revert Display all purchase suggestions whether or
> not suggestion was added
>
>This does not work correctly and should be handle on another bug report.
>The behavior existed prior to this patchset.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> opac/opac-suggestions.pl | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl
>index 52c0775..1cc96c2 100755
>--- a/opac/opac-suggestions.pl
>+++ b/opac/opac-suggestions.pl
>@@ -148,14 +148,16 @@ if ( $op eq "add_confirm" ) {
>         $suggestion->{branchcode} = $input->param('branchcode') || C4::Context->userenv->{"branch"};
> 
>         &NewSuggestion($suggestion);
>+
>+        # delete empty fields, to avoid filter in "SearchSuggestion"
>+        foreach my $field ( qw( title author publishercode copyrightdate place collectiontitle isbn STATUS ) ) {
>+            delete $suggestion->{$field}; #clear search filters (except borrower related) to show all suggestions after placing a new one
>+        }
>+        $suggestions_loop = &SearchSuggestion($suggestion);
>+
>         push @messages, { type => 'info', code => 'success_on_inserted' };
> 
>     }
>-    # delete empty fields, to avoid filter in "SearchSuggestion" and load all suggestions for display
>-    foreach my $field ( qw( title author publishercode copyrightdate place collectiontitle isbn STATUS ) ) {
>-        delete $suggestion->{$field}; #clear search filters (except borrower related) to show all suggestions after placing a new one
>-    }
>-    $suggestions_loop = &SearchSuggestion($suggestion);
>     $op = 'else';
> }
> 
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 15128: 52452 | 52502 | 52596 | 52610 | 52611 | 52623 | 52624 | 52625 | 52626 | 52715 | 52716 | 52717 | 52718 | 52719 | 52720 | 52721 | 52722 | 52997 | 53033 | 53034 | 53037 | 53038 | 53039 | 53040 | 53041 | 53042 | 53043 | 53044 | 53045