Attachment 53135 Details for Bug 15006 – Proposed patch

[patch] Proposed patch

0004-Bug-15006-Correct-indentation-of-EXPORTs-in-Sip.pm.patch (text/plain), 1.77 KB, created by Colin Campbell on 2016-07-06 15:03:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Colin Campbell

Created: 2016-07-06 15:03:57 UTC

Size: 1.77 KB

patch

obsolete

>From 87008df8d29629472750a254962b46840dd8616f Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Wed, 6 Jul 2016 15:25:21 +0100
>Subject: [PATCH 4/4] Bug 15006 Correct indentation of EXPORTs in Sip.pm
>
>Removed tabs and used spaces consistently
>Used 'use base' to remove unnecessary BEGIN sub and
>explicit setting of ISA at application level
>---
> C4/SIP/Sip.pm | 31 +++++++++++++------------------
> 1 file changed, 13 insertions(+), 18 deletions(-)
>
>diff --git a/C4/SIP/Sip.pm b/C4/SIP/Sip.pm
>index a5ebdeb..15bb9a3 100644
>--- a/C4/SIP/Sip.pm
>+++ b/C4/SIP/Sip.pm
>@@ -16,24 +16,19 @@ use IO::Handle;
> use C4::SIP::Sip::Constants qw(SIP_DATETIME FID_SCREEN_MSG);
> use C4::SIP::Sip::Checksum qw(checksum);
> 
>-use vars qw(@ISA @EXPORT_OK %EXPORT_TAGS);
>-
>-BEGIN {
>-	@ISA = qw(Exporter);
>-
>-	@EXPORT_OK = qw(y_or_n timestamp add_field maybe_add add_count
>-		    denied sipbool boolspace write_msg get_timeout
>-		    $error_detection $protocol_version $field_delimiter
>-		    $last_response);
>-
>-	%EXPORT_TAGS = (
>-		    all => [qw(y_or_n timestamp add_field maybe_add
>-			       add_count denied sipbool boolspace write_msg
>-                   get_timeout
>-			       $error_detection $protocol_version
>-			       $field_delimiter $last_response)]);
>-}
>-
>+use base qw(Exporter);
>+
>+our @EXPORT_OK = qw(y_or_n timestamp add_field maybe_add add_count
>+    denied sipbool boolspace write_msg get_timeout
>+    $error_detection $protocol_version $field_delimiter
>+    $last_response);
>+
>+our %EXPORT_TAGS = (
>+    all => [qw(y_or_n timestamp add_field maybe_add
>+        add_count denied sipbool boolspace write_msg
>+        get_timeout
>+        $error_detection $protocol_version
>+        $field_delimiter $last_response)]);
> 
> our $error_detection = 0;
> our $protocol_version = 1;
>-- 
>2.7.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 15006: 45039 | 45583 | 45594 | 52477 | 52478 | 52479 | 52480 | 52784 | 52785 | 52786 | 52787 | 52849 | 52850 | 52851 | 52852 | 52853 | 53009 | 53010 | 53011 | 53012 | 53013 | 53014 | 53132 | 53133 | 53134 | 53135 | 53309 | 53310 | 53311 | 53312 | 53355 | 53356 | 53357 | 53358 | 53359 | 53360 | 53363 | 53364 | 53365 | 53366 | 53367 | 53368 | 53369