Bugzilla – Attachment 53137 Details for
Bug 16810
Fines note not showing on checkout
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF]Bug 16810: Fines note not showing on checkout
SIGNED-OFFBug-16810-Fines-note-not-showing-on-chec.patch (text/plain), 2.70 KB, created by
Héctor Eduardo Castro Avalos
on 2016-07-06 15:19:15 UTC
(
hide
)
Description:
[SIGNED-OFF]Bug 16810: Fines note not showing on checkout
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2016-07-06 15:19:15 UTC
Size:
2.70 KB
patch
obsolete
>From 851c81460bafcf7159ecbefacd213d48436ab95b Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Mon, 4 Jul 2016 14:30:24 +0200 >Subject: [PATCH] [SIGNED-OFF]Bug 16810: Fines note not showing on checkout > >Fines did not show on patron checkout and detail pages unless amout >was greater than syspref NoIssueCharges. > >This patch fixes the logic in >koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc > >Additionally, it changes links to buttons and makes some small >text changes to ease translation. > >To test: >- Apply patch >- Display checkout or detail page and verify proper display for > a patron who has > - no fines (no message) > - fines not exceeding syspref NoissueCharges (message) > - fines exceeding syspref NoIssueCharges (message) > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as advertised >--- > .../prog/en/includes/blocked-fines.inc | 21 ++++++-------------- > 1 file changed, 6 insertions(+), 15 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc >index 596c0c7..0789789 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc >@@ -1,22 +1,13 @@ > [% USE Price %] > [% SET NoIssuesCharge = Koha.Preference('noissuescharge') %] >- >-[% IF NoIssuesCharge && fines > NoIssuesCharge %] >+[% IF fines > 0 %] > <li> > <span class="circ-hlt">Fees & Charges:</span> >- Patron has <a href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% borrowernumber %]"> >- Outstanding fees & charges >- [% IF ( fines ) %] >- of [% fines | $Price %] >- [% END %] >- </a>. >- >- [% IF !Koha.Preference('AllowFineOverride') %] >- <span class="circ-hlt">Checkouts are BLOCKED because fine balance is OVER THE LIMIT.</span> >+ Patron has outstanding fees & charges of [% fines | $Price %]. >+ [% IF !Koha.Preference('AllowFineOverride') && NoIssuesCharge && fines > NoIssuesCharge %] >+ <span class="circ-hlt">Checkouts are BLOCKED because fine balance is OVER THE LIMIT.</span> > [% END %] >- >- <a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% borrowernumber %]">Make payment</a> >- or >- <a href="/cgi-bin/koha/members/paycollect.pl?borrowernumber=[% borrowernumber %]">Pay all fines</a></li> >+ <a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% borrowernumber %]" class="btn btn-mini" >Make payment</a> >+ <a href="/cgi-bin/koha/members/paycollect.pl?borrowernumber=[% borrowernumber %]" class="btn btn-mini" >Pay all fines</a></li> > </li> > [% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16810
:
52865
|
53125
|
53137
|
53301