Bugzilla – Attachment 53140 Details for
Bug 9259
Delete marc batches from staged marc management
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9259: Use is instead of is_deeply
Bug-9259-Use-is-instead-of-isdeeply.patch (text/plain), 2.48 KB, created by
Jonathan Druart
on 2016-07-06 15:58:18 UTC
(
hide
)
Description:
Bug 9259: Use is instead of is_deeply
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-07-06 15:58:18 UTC
Size:
2.48 KB
patch
obsolete
>From 0281bf0ac5279a6829d30037c22a4d8d83e2e6da Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 6 Jul 2016 16:57:05 +0100 >Subject: [PATCH] Bug 9259: Use is instead of is_deeply > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt | 3 ++- > t/db_dependent/ImportBatch.t | 6 ++---- > 2 files changed, 4 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt >index e6bf950..e1119d1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt >@@ -454,7 +454,8 @@ Page > <td>[% batch_lis.upload_timestamp %]</td> > <td>[% batch_lis.num_records %]</td> > <td>[% batch_lis.num_items %][% IF ( batch_lis.num_items ) %] <a href="[% batch_lis.script_name %]?import_batch_id=[% batch_lis.import_batch_id %]&op=create_labels">(Create label batch)</a>[% END %]</td> >- <td class="actions">[% IF ( batch_lis.can_clean ) %] >+ <td class="actions"> >+ [% IF ( batch_lis.can_clean ) %] > <form method="post" action="[% batch_lis.script_name %]" name="clean_batch_[% batch_lis.import_batch_id %]" id="clean_batch_[% batch_lis.import_batch_id %]" > > <input type="hidden" name="import_batch_id" value="[% batch_lis.import_batch_id %]" /> > <input type="hidden" name="op" value="clean-batch" /> >diff --git a/t/db_dependent/ImportBatch.t b/t/db_dependent/ImportBatch.t >index 8cb84ce..156b505 100644 >--- a/t/db_dependent/ImportBatch.t >+++ b/t/db_dependent/ImportBatch.t >@@ -138,11 +138,9 @@ my $id_import_batch3 = C4::ImportBatch::AddImportBatch($sample_import_batch3); > # Test CleanBatch > C4::ImportBatch::CleanBatch( $id_import_batch3 ); > my $batch3_clean = $dbh->do('SELECT * FROM import_records WHERE import_batch_id = "$id_import_batch3"'); >-is_deeply( $batch3_clean, "0E0", >- "Batch 3 has been cleaned" ); >+is( $batch3_clean, "0E0", "Batch 3 has been cleaned" ); > > # Test DeleteBatch > C4::ImportBatch::DeleteBatch( $id_import_batch3 ); > my $batch3_results = $dbh->do('SELECT * FROM import_batches WHERE import_batch_id = "$id_import_batch3"'); >-is_deeply( $batch3_results, "0E0", # 0E0 == 0 >- "Batch 3 has been deleted"); >+is( $batch3_results, "0E0", "Batch 3 has been deleted"); >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9259
:
49609
|
49746
|
53007
|
53116
|
53139
| 53140