Bugzilla – Attachment 53231 Details for
Bug 16888
Add Font Awesome Icons to Members
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16888: Add Font Awesome Icons to Members
Bug-16888-Add-Font-Awesome-Icons-to-Members.patch (text/plain), 5.73 KB, created by
Héctor Eduardo Castro Avalos
on 2016-07-08 22:01:32 UTC
(
hide
)
Description:
Bug 16888: Add Font Awesome Icons to Members
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2016-07-08 22:01:32 UTC
Size:
5.73 KB
patch
obsolete
>From 8056a8ea214bf89464d2363991e82dc29ac81d99 Mon Sep 17 00:00:00 2001 >From: Hector Castro <hector.hecaxmmx@gmail.com> >Date: Fri, 8 Jul 2016 15:52:06 -0600 >Subject: [PATCH] Bug 16888: Add Font Awesome Icons to Members > >Add Font Awesome Icons to: >- "Select/Clear all" links to pay.tt (Pay fines tab) >- "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) >- "Trash icon" to Remove option in "Manual restrictions" >(borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" > >To test: >-Apply patch >-Select a patron who has fines >-Go to "Fines->Pay fines" tabs and see the icons in "Select/Clear all" >-Choose the "Account" tab and sse the icon in "Filter paid transactions" >-Select the "Check out" tab and go to "Restrictions" >-Add a manual restriction and notice about the two new icons fa-plus and fa-band >-See the new button btn-mini and the fa-trash icon >-Verify that all works as expected >--- > .../intranet-tmpl/prog/en/includes/borrower_debarments.inc | 8 ++++---- > koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt | 6 +++--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 2 +- > 3 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc >index b0e3230..a9d80cd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc >@@ -66,8 +66,8 @@ > <td>[% IF d.expiration %] [% d.expiration | $KohaDates %] [% ELSE %] <i>Indefinite</i> [% END %]</td> > [% IF CAN_user_borrowers && CAN_user_circulate_manage_restrictions %] > <td> >- <a class="remove_restriction" href="/cgi-bin/koha/members/mod_debarment.pl?borrowernumber=[% borrowernumber %]&borrower_debarment_id=[% d.borrower_debarment_id %]&action=del"> >- Remove >+ <a class="remove_restriction btn btn-mini" href="/cgi-bin/koha/members/mod_debarment.pl?borrowernumber=[% borrowernumber %]&borrower_debarment_id=[% d.borrower_debarment_id %]&action=del"> >+ <i class="fa fa-trash"></i> Remove > </a> > </td> > [% END %] >@@ -77,12 +77,12 @@ > </table> > [% END %] > [% IF CAN_user_borrowers && CAN_user_circulate_manage_restrictions %] >- <p><a href="#" id="add_manual_restriction">Add manual restriction</a></p> >+ <p><a href="#" id="add_manual_restriction"><i class="fa fa-plus"></i> Add manual restriction</a></p> > <form method="post" action="/cgi-bin/koha/members/mod_debarment.pl" class="clearfix"> > <input type="hidden" name="borrowernumber" value="[% borrowernumber %]" /> > <input type="hidden" name="action" value="add" /> > <fieldset class="rows" id="manual_restriction_form"> >- <legend>Add manual restriction</legend> >+ <legend><i class="fa fa-ban"></i> Add manual restriction</legend> > <ol> > <li><label for="rcomment">Comment:</label> <input type="text" id="rcomment" name="comment" /></li> > <li><label for="rexpiration">Expiration:</label> <input name="expiration" id="rexpiration" size="10" readonly="readonly" value="" class="datepicker" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >index 5eb3c40..ca0a804 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >@@ -18,15 +18,15 @@ $(document).ready(function() { > { "bSortable": false, "bSearchable": false, "aTargets": [-1] } > ] > })); >- $("#filter_c").html('<p><a href="#" id="filter_transacs">'+txtActivefilter+'</a>'); >+ $("#filter_c").html('<p><a href="#" id="filter_transacs"><i class="fa fa-filter"></i> '+txtActivefilter+'</a>'); > $('#filter_transacs').click(function(e) { > e.preventDefault(); > if ($(this).hasClass('filtered')) { > var filteredValue = ''; >- $(this).text(txtActivefilter); >+ $(this).html('<i class="fa fa-filter"></i> '+txtActivefilter); > } else { //Not filtered. Let's do it! > var filteredValue = '^((?!0.00).*)$'; //Filter not matching 0.00 http://stackoverflow.com/a/406408 >- $(this).text(txtInactivefilter); >+ $(this).html('<i class="fa fa-filter"></i> '+txtInactivefilter); > } > table_account_fines.fnFilter(filteredValue, 4, true, false); > $(this).toggleClass('filtered'); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >index ee57b27..cb635b1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >@@ -68,7 +68,7 @@ function enableCheckboxActions(){ > [% IF ( accounts ) %] > <form action="/cgi-bin/koha/members/pay.pl" method="post" id="pay-fines-form"> > <input type="hidden" name="borrowernumber" id="borrowernumber" value="[% borrower.borrowernumber %]" /> >-<p><span class="checkall"><a id="CheckAll" href="#">Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#">Clear all</a></span></p> >+<p><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></p> > <table id="finest"> > <thead> > <tr> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16888
:
53230
|
53231
|
53250
|
53266
|
53281
|
53282