Attachment 53344 Details for Bug 16913 – Bug 16913: Koha::Patrons - Remove GetBorrowersNamesAndLatestIssue

[patch] Bug 16913: Koha::Patrons - Remove GetBorrowersNamesAndLatestIssue

Bug-16913-KohaPatrons---Remove-GetBorrowersNamesAn.patch (text/plain), 1.73 KB, created by Jonathan Druart on 2016-07-12 19:13:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-07-12 19:13:15 UTC

Size: 1.73 KB

patch

obsolete

>From f362ef955a7aef3fbfe9ff3a2539500c1591780e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 12 Jul 2016 08:37:33 +0100
>Subject: [PATCH] Bug 16913: Koha::Patrons - Remove
> GetBorrowersNamesAndLatestIssue
>
>This subroutine has been added by
>  commit 5904681faca77c87ff8071414d66e123a2d3baa9
>  Date:   Wed Mar 19 10:11:12 2008 -0500
>    CleanBorrowers fixing.
>but has never been used.
>It can be removed safely.
>
>Test plan:
>  git grep GetBorrowersNamesAndLatestIssue
>should not return any results.
>---
> C4/Members.pm | 26 --------------------------
> 1 file changed, 26 deletions(-)
>
>diff --git a/C4/Members.pm b/C4/Members.pm
>index f9b3942..1cf619d 100644
>--- a/C4/Members.pm
>+++ b/C4/Members.pm
>@@ -1963,32 +1963,6 @@ sub GetBorrowersWithIssuesHistoryOlderThan {
>     return \@results;
> }
> 
>-=head2 GetBorrowersNamesAndLatestIssue
>-
>-  $results = &GetBorrowersNamesAndLatestIssueList(@borrowernumbers)
>-
>-this function get borrowers Names and surnames and Issue information.
>-
>-I<@borrowernumbers> is an array which all elements are borrowernumbers.
>-This hashref is containt the number of time this borrowers has borrowed before I<$date> and the borrowernumber.
>-
>-=cut
>-
>-sub GetBorrowersNamesAndLatestIssue {
>-    my $dbh  = C4::Context->dbh;
>-    my @borrowernumbers=@_;  
>-    my $query = "
>-       SELECT surname,lastname, phone, email,max(timestamp)
>-       FROM borrowers 
>-         LEFT JOIN issues ON borrowers.borrowernumber=issues.borrowernumber
>-       GROUP BY borrowernumber
>-   ";
>-    my $sth = $dbh->prepare($query);
>-    $sth->execute;
>-    my $results = $sth->fetchall_arrayref({});
>-    return $results;
>-}
>-
> =head2 ModPrivacy
> 
>   my $success = ModPrivacy( $borrowernumber, $privacy );
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 16913: 53344 | 53388 | 53413