Attachment 53351 Details for Bug 16897 – [PASSED QA] Bug 16897 - Re-focus on "Add item" in Lists

[patch] [PASSED QA] Bug 16897 - Re-focus on "Add item" in Lists

PASSED-QA-Bug-16897---Re-focus-on-Add-item-in-List.patch (text/plain), 3.87 KB, created by Katrin Fischer on 2016-07-12 21:02:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-07-12 21:02:11 UTC

Size: 3.87 KB

patch

obsolete

>From b31cce0e56a406e23a2955bc1bd738ec4f19e5f2 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 11 Jul 2016 16:31:18 +0200
>Subject: [PATCH] [PASSED QA] Bug 16897 - Re-focus on "Add item" in Lists
>
>Bug 11325 add solved a focus on "Add item" missing in Lists page.
>Since revamping of this page, the add item form exists both in page.
>The one corrected by Bug 11325 is not visible because it checks a bad
>var allowaddingitem instead of can_add_biblios.
>
>This patch removes the first form and corrects the second form.
>It moves the form at left part of page so that it is always shown
>(usefull when there are a lot of items). It does not add the list name
>after "Add item" besause it whould be huggly for long names and because
>listname already exists in breadscrumbs and on top of the table.
>It also adds autocomplete="off" on barcode input because there can be
>problems with a scanning device.
>
>Test instructions:
>1. Create a list
>2. Make sure you have an object with an assigned barcode
>3. Go to the list
>   => The barcode entry interface should be at left and has the focus
>4. Enter the barcode and press enter (or use a scanner)
>   => The item is added to the list
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>This is a nice improvement, thanks!
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../prog/en/modules/virtualshelves/shelves.tt      | 35 +++++-----------------
> 1 file changed, 8 insertions(+), 27 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>index 9c667fe..4982909 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>@@ -496,26 +496,6 @@ function placeHold () {
>    </div>
> [% END %]
> 
>-[% IF can_add_biblios %]
>-<div class="yui-g">
>-<form action="/cgi-bin/koha/virtualshelves/shelves.pl" method="post">
>- <fieldset class="brief noprint">
>-    <legend>Add an item to <i>[% shelf.shelfname | html %]</i></legend>
>-        <ol>
>-            <li>
>-                <label for="barcode">Barcode:</label>
>-                <input name="barcode" type="text" id="barcode" size="14" />
>-                <input type="hidden" name="op" value="add_biblio" />
>-                <input type="hidden" name="referer" value="view" />
>-                <input type="hidden" name="shelfnumber" value="[% shelf.shelfnumber %]" />
>-                <input type="submit" value="Add" />
>-            </li>
>-        </ol>
>- </fieldset>
>-</form>
>-</div>
>-[% END %]
>-
> [% IF op == 'add_form' OR op == 'edit_form' %]
> <div class="yui-ge">
>     <div class="yui-u first">
>@@ -675,17 +655,18 @@ function placeHold () {
> </div>
> </div>
> 
>-[% IF ( allowaddingitem ) %]
>+[% IF ( can_add_biblios ) %]
> <div class="yui-b">
>   <form action="/cgi-bin/koha/virtualshelves/shelves.pl" method="post">
>-    <fieldset class="brief">
>+    <fieldset class="brief noprint">
>       <legend>Add an item</legend>
>       <ol>
>         <li>
>-          <label for="addbarcode">Barcode:</label>
>-          <input name="addbarcode" type="text" id="addbarcode" class="focus" />
>-          <input type="hidden" name="viewshelf" value="[% shelfnumber %]" />
>-          <input type="hidden" name="modifyshelfcontents" value="1" />
>+          <label for="barcode">Barcode:</label>
>+          <input name="barcode" type="text" id="barcode" class="focus" autocomplete="off" />
>+          <input type="hidden" name="op" value="add_biblio" />
>+          <input type="hidden" name="referer" value="view" />
>+          <input type="hidden" name="shelfnumber" value="[% shelf.shelfnumber %]" />
>         </li>
>       </ol>
>       <fieldset class="action">
>@@ -694,7 +675,7 @@ function placeHold () {
>     </fieldset>
>   </form>
> </div>
>-[% END %]
>+[% END %]
> 
> </div>
> [% INCLUDE 'intranet-bottom.inc' %]
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 16897: 53267 | 53304 | 53351