Attachment 53369 Details for Bug 15006 – Bug 15006: [QA Follow-up] Only handle login requests in raw_transport

[patch] Bug 15006: [QA Follow-up] Only handle login requests in raw_transport

Bug-15006-QA-Follow-up-Only-handle-login-requests-.patch (text/plain), 1.43 KB, created by Marcel de Rooy on 2016-07-13 12:24:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2016-07-13 12:24:41 UTC

Size: 1.43 KB

patch

obsolete

>From 36e794e32a8f8dcd1164cafc11e6a799fbad212d Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 13 Jul 2016 11:59:28 +0200
>Subject: [PATCH] Bug 15006: [QA Follow-up] Only handle login requests in
> raw_transport
>Content-Type: text/plain; charset=utf-8
>
>Although mainly hypothetical, it would still be possible to get
>response from the server for an acs resend request. (This exception
>is allowed in MsgType::handle.)
>I also noticed that the response may well be a message from an older
>session still.
>This patch just removes that exception by only passing login requests
>to sub handle in the raw_transport loop.
>
>Test plan:
>[1] Verify normal login procedure for raw.
>[2] Check a few acs resend requests in raw. They should terminate without
>    a response.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/SIP/SIPServer.pm |    4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/C4/SIP/SIPServer.pm b/C4/SIP/SIPServer.pm
>index 814e0ff..5e1e3a6 100755
>--- a/C4/SIP/SIPServer.pm
>+++ b/C4/SIP/SIPServer.pm
>@@ -146,7 +146,9 @@ sub raw_transport {
>             return;
>         }
>         $input =~ s/[\r\n]+$//sm; # Strip off trailing line terminator(s)
>-        last if C4::SIP::Sip::MsgType::handle($input, $self, LOGIN);
>+        my $reg = qr/^${\(LOGIN)}/;
>+        last if $input !~ $reg ||
>+            C4::SIP::Sip::MsgType::handle($input, $self, LOGIN);
>     }
>     alarm 0;
> 
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 15006: 45039 | 45583 | 45594 | 52477 | 52478 | 52479 | 52480 | 52784 | 52785 | 52786 | 52787 | 52849 | 52850 | 52851 | 52852 | 52853 | 53009 | 53010 | 53011 | 53012 | 53013 | 53014 | 53132 | 53133 | 53134 | 53135 | 53309 | 53310 | 53311 | 53312 | 53355 | 53356 | 53357 | 53358 | 53359 | 53360 | 53363 | 53364 | 53365 | 53366 | 53367 | 53368 | 53369