Bugzilla – Attachment 53412 Details for
Bug 16917
Error when importing patrons, Column 'checkprevcheckout' cannot be null
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16917 - Error when importing patrons, Column 'checkprevcheckout' cannot be null
Bug-16917---Error-when-importing-patrons-Column-ch.patch (text/plain), 1.56 KB, created by
Marcel de Rooy
on 2016-07-15 07:14:10 UTC
(
hide
)
Description:
Bug 16917 - Error when importing patrons, Column 'checkprevcheckout' cannot be null
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-07-15 07:14:10 UTC
Size:
1.56 KB
patch
obsolete
>From 92665e9be4000a852c8e4656ead35b37ee1f8a44 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 13 Jul 2016 15:41:30 +0000 >Subject: [PATCH] Bug 16917 - Error when importing patrons, Column > 'checkprevcheckout' cannot be null >Content-Type: text/plain; charset=utf-8 > >Error: >DBIx::Class::Storage::DBI::_dbh_execute(): Column 'checkprevcheckout' >cannot be null at C4/Members.pm line 697 > >Test Plan: >1) Attempt to import a patron via csv >2) Note the error >3) Apply this patch >4) Repeat the import >5) No error! > >NOTE: Given that all the other tests ran (comment #2), except > those in comment #3, I resorted to following the test plan > above using the attachment provided in comment #5. I > believe the issues in comment #3 constitute other bugs > which need fixing and are unrelated this bug. Applying the > patch does resolve the error triggered, and the code is > good. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Members.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Members.pm b/C4/Members.pm >index f9b3942..677e221 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -726,6 +726,7 @@ sub AddMember { > # get only the columns of Borrower > my @columns = $schema->source('Borrower')->columns; > my $new_member = { map { join(' ',@columns) =~ /$_/ ? ( $_ => $data{$_} ) : () } keys(%data) } ; >+ $new_member->{checkprevcheckout} ||= 'inherit'; > delete $new_member->{borrowernumber}; > > my $rs = $schema->resultset('Borrower'); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16917
:
53378
|
53398
|
53405
| 53412