Bugzilla – Attachment 53537 Details for
Bug 16934
Cannot add notes to canceled and deleted order line
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16934 - Cannot add notes to canceled and deleted order line
Bug-16934---Cannot-add-notes-to-canceled-and-delet.patch (text/plain), 1.45 KB, created by
Claire Gravely
on 2016-07-20 20:11:19 UTC
(
hide
)
Description:
Bug 16934 - Cannot add notes to canceled and deleted order line
Filename:
MIME Type:
Creator:
Claire Gravely
Created:
2016-07-20 20:11:19 UTC
Size:
1.45 KB
patch
obsolete
>From bfb9ffb4596352d7994e3afd37ad793ae3a52312 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 18 Jul 2016 11:02:14 +0000 >Subject: [PATCH] Bug 16934 - Cannot add notes to canceled and deleted order > line > >Some librarians would like to be able to add notes to deleted order >lines to keep track of data such as what title the order line was for. >For some reason ModOrder dies if a biblionumber is passed in, even >though it does not use biblionumber and does not need it to exist in any >fashion! This limitation should be removed. > >Test Plan: >1) Create a basket with an orderline >2) Cancel the order / delete the record >3) Click the "Add internal note" link for that order line >4) Fill in a note and click "Save" >5) Note the error >6) Apply this patch >7) Repeat steps 3-4 >8) Note this time the note is saved! > >Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> >--- > C4/Acquisition.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index c091f89..6894cb4 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -1263,8 +1263,7 @@ table of the Koha database. > sub ModOrder { > my $orderinfo = shift; > >- die "Ordernumber is required" if $orderinfo->{'ordernumber'} eq '' ; >- die "Biblionumber is required" if $orderinfo->{'biblionumber'} eq ''; >+ die "Ordernumber is required" if $orderinfo->{'ordernumber'} eq ''; > > my $dbh = C4::Context->dbh; > my @params; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16934
:
53472
|
53537
|
53598
|
53599