Attachment 53589 Details for Bug 6934 – Bug 6934: QA follow-up

[patch] Bug 6934: QA follow-up

Bug-6934-QA-follow-up.patch (text/plain), 3.54 KB, created by Bouzid Fergani on 2016-07-21 15:34:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bouzid Fergani

Created: 2016-07-21 15:34:39 UTC

Size: 3.54 KB

patch

obsolete

>From 9bf53ecc528a7163ed027e17e3d4c6bdf3bd7888 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Thu, 28 Apr 2016 19:58:32 +0200
>Subject: [PATCH] Bug 6934: QA follow-up
>
>- fixed tabs
>- fixed capitalization on reports start page
>---
> .../prog/en/modules/reports/reports-home.tt        |  2 +-
> reports/cash_register_stats.pl                     | 38 ++++++++++------------
> 2 files changed, 19 insertions(+), 21 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
>index 9815071..18eedd2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
>@@ -35,7 +35,7 @@
> 		<li><a href="/cgi-bin/koha/reports/catalogue_stats.pl">Catalog</a></li>
> 		<li><a href="/cgi-bin/koha/reports/issues_stats.pl">Circulation</a></li>
> 		<li><a href="/cgi-bin/koha/reports/serials_stats.pl">Serials</a></li>
>-        <li><a href="/cgi-bin/koha/reports/cash_register_stats.pl">Cash Register</a></li>
>+        <li><a href="/cgi-bin/koha/reports/cash_register_stats.pl">Cash register</a></li>
> 		<li><a href="/cgi-bin/koha/reports/reserves_stats.pl">Holds</a></li>
>       </ul>
> 
>diff --git a/reports/cash_register_stats.pl b/reports/cash_register_stats.pl
>index 7e7cb44..409aa4e 100755
>--- a/reports/cash_register_stats.pl
>+++ b/reports/cash_register_stats.pl
>@@ -25,8 +25,6 @@ use C4::Circulation;
> use DateTime;
> use Koha::DateUtils;
> use Text::CSV::Encoded;
>-#use Data::Dumper;
>-#use Smart::Comments;
> 
> my $input            = new CGI;
> my $dbh              = C4::Context->dbh;
>@@ -153,32 +151,32 @@ if ($do_it) {
>             $csv or die "Text::CSV::Encoded->new({binary => 1}) FAILED: " . Text::CSV::Encoded->error_diag();
>             my @headers = ();
>             push @headers, "mfirstname",
>-			            "cardnumber",
>-			            "bfirstname",
>-			            "branchname",
>-			            "date",
>-			            "accounttype",
>-			            "amount",
>-			            "title",
>-			            "barcode",
>-			            "itype";
>+                        "cardnumber",
>+                        "bfirstname",
>+                        "branchname",
>+                        "date",
>+                        "accounttype",
>+                        "amount",
>+                        "title",
>+                        "barcode",
>+                        "itype";
>             if ($csv->combine(@headers)) {
>                 $content .= Encode::decode('UTF-8', $csv->string()) . "\n";
>             } else {
>                 push @$q_errors, { combine => 'HEADER ROW: ' . $csv->error_diag() } ;
>             }
>             foreach my $row (@loopresult) {
>-				my @rowValues = ();
>+                my @rowValues = ();
>                 push @rowValues, $row->{mfirstname},
>                         $row->{cardnumber},
>-						$row->{bfirstname},
>-						$row->{branchname},
>-						$row->{date},
>-						$row->{accounttype},
>-						$row->{amount},
>-						$row->{title},
>-						$row->{barcode};
>-						$row->{itype};
>+                        $row->{bfirstname},
>+                        $row->{branchname},
>+                        $row->{date},
>+                        $row->{accounttype},
>+                        $row->{amount},
>+                        $row->{title},
>+                        $row->{barcode};
>+                        $row->{itype};
>                 if ($csv->combine(@rowValues)) {
>                     $content .= Encode::decode('UTF-8',$csv->string()) . "\n";
>                 } else {
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 6934: 5634 | 5635 | 5640 | 5641 | 9379 | 9419 | 12602 | 12660 | 31210 | 36476 | 42564 | 42565 | 44847 | 44853 | 45972 | 45973 | 45974 | 48634 | 48642 | 48704 | 48705 | 48706 | 48707 | 48708 | 50429 | 50437 | 50938 | 53496 | 53500 | 53570 | 53571 | 53572 | 53573 | 53574 | 53575 | 53576 | 53577 | 53578 | 53579 | 53581 | 53582 | 53583 | 53584 | 53585 | 53586 | 53587 | 53588 | 53589 | 53590 | 53591 | 53648 | 53650 | 53651 | 53652 | 53653 | 53778 | 53780 | 54010 | 54088 | 54089 | 54090 | 54091 | 54092 | 54093 | 54094 | 54095 | 54096 | 54097 | 54098 | 54099 | 54100 | 55939 | 55988 | 55989 | 55990 | 55991 | 55992 | 55993 | 55994 | 55995 | 55996 | 55997 | 55998 | 55999 | 56000 | 56001 | 56763 | 56764