Attachment 53669 Details for Bug 16969 – Bug 16969 cgi->param used in list context in opac-memberentry.pl

[patch] Bug 16969 cgi->param used in list context in opac-memberentry.pl

Bug-16969-cgi-param-used-in-list-context-in-opac-m.patch (text/plain), 1.14 KB, created by Marcel de Rooy on 2016-07-24 14:16:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2016-07-24 14:16:35 UTC

Size: 1.14 KB

patch

obsolete

>From 80bc461b9b8239f8cfbf67898756e68a88ec67f8 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Sun, 24 Jul 2016 19:18:51 +1200
>Subject: [PATCH] Bug 16969 cgi->param used in list context in
> opac-memberentry.pl
>Content-Type: text/plain; charset=utf-8
>
>To test
>1/ Hit the page, notice the warning in the log
>2/ Apply patch
>3/ Hit page, notice no warning in the log
>4/ Test functionality all still works
>
>Works as expected. (Note: See Bug 16960 for updating patron details).
>Signed-off-by: Marc <veron@veron.ch>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> opac/opac-memberentry.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl
>index ddd66a7..ffa0018 100755
>--- a/opac/opac-memberentry.pl
>+++ b/opac/opac-memberentry.pl
>@@ -373,7 +373,7 @@ sub ParseCgiForBorrower {
>     foreach ( $cgi->param ) {
>         if ( $_ =~ '^borrower_' ) {
>             my ($key) = substr( $_, 9 );
>-            $borrower{$key} = $scrubber->scrub( $cgi->param($_) );
>+            $borrower{$key} = $scrubber->scrub( scalar $cgi->param($_) );
>         }
>     }
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16969: 53667 | 53668 | 53669