Bugzilla – Attachment 53681 Details for
Bug 15397
Pay selected does not works as expected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15397 - Pay selected does not works as expected
Bug-15397---Pay-selected-does-not-works-as-expecte.patch (text/plain), 1.55 KB, created by
Jonathan Druart
on 2016-07-25 12:42:09 UTC
(
hide
)
Description:
Bug 15397 - Pay selected does not works as expected
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-07-25 12:42:09 UTC
Size:
1.55 KB
patch
obsolete
>From 25e9c66602a3a1e14ef451254c157ccf7b04a9b7 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 19 May 2016 13:28:02 +0000 >Subject: [PATCH] Bug 15397 - Pay selected does not works as expected > >When patron has more fees (account lines) and you wan't to pay just some >of them, you select wanted lines a click on "pay selected" button. But >the fine isn't paid, the "amountoutstandig" is not modified, but it is >added new line with "pay" code an with amountoutstanding below zero. >Paying one or all fine works as expected. Paying selected worked some >time ago, but I don't know when it stopped working, we realize it after >upgrade to 3.22. > >Test Plan: >1) Apply this patch >2) Pay fines using "Pay selected" >3) Note the payment and the fees outstanding balances are reduced! > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Accounts.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Accounts.pm b/C4/Accounts.pm >index 5243712..485e453 100644 >--- a/C4/Accounts.pm >+++ b/C4/Accounts.pm >@@ -606,7 +606,7 @@ sub recordpayment_selectaccts { > my $sql = 'SELECT * FROM accountlines WHERE (borrowernumber = ?) ' . > 'AND (amountoutstanding<>0) '; > if (@{$accts} ) { >- $sql .= ' AND accountno IN ( ' . join ',', @{$accts}; >+ $sql .= ' AND accountlines_id IN ( ' . join ',', @{$accts}; > $sql .= ' ) '; > } > $sql .= ' ORDER BY date'; >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15397
:
49009
|
49574
|
53486
|
53490
| 53681