Bugzilla – Attachment 53688 Details for
Bug 11879
Add a new field to patron record: main contact method
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11879 - QA Follow-up
Bug-11879---QA-Follow-up.patch (text/plain), 2.75 KB, created by
Mehdi Hamidi
on 2016-07-25 15:00:37 UTC
(
hide
)
Description:
Bug 11879 - QA Follow-up
Filename:
MIME Type:
Creator:
Mehdi Hamidi
Created:
2016-07-25 15:00:37 UTC
Size:
2.75 KB
patch
obsolete
>From 11b165aa7af44b7b152e44608e8728619eb6a1a7 Mon Sep 17 00:00:00 2001 >From: mehdi <mehdi@inlibro.com> >Date: Mon, 25 Jul 2016 10:56:36 -0400 >Subject: [PATCH] Bug 11879 - QA Follow-up > >Fixed tests, they now work without any fails >--- > t/db_dependent/Letters.t | 9 ++------- > t/db_dependent/Members.t | 6 +++--- > 2 files changed, 5 insertions(+), 10 deletions(-) > >diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t >index bec56ef..bf773f0 100755 >--- a/t/db_dependent/Letters.t >+++ b/t/db_dependent/Letters.t >@@ -18,7 +18,7 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; >-use Test::More tests => 74; >+use Test::More tests => 79; > use Test::MockModule; > use Test::Warn; > >@@ -165,7 +165,7 @@ my $guarantee = { > }; > $guarantee->{'borrowernumber'} = AddMember(%$guarantee); > >-my $GUARANTEE_TO_ADDRESS = 'toto@exemple.com'; >+my $GUARANTEE_TO_ADDRESS = 'guarantor@example.com'; > my $guarantee_message = { > borrowernumber => $guarantee->{'borrowernumber'}, > message_transport_type => 'email', >@@ -192,11 +192,6 @@ $result = SendToGuarantor(1,$guarantee_message); > is($result->{'status'}, "sent", "With EnableRedirectGuaranteeEmail on, message is sent."); > is($result->{'to_address'}, $GUARANTOR_EMAIL, "With EnableRedirectGuaranteeEmail on, Message is sent to the guarantor's email address."); > >-$guarantor->{'email'} = undef; >-ModMember(%$guarantor); >-$result = SendToGuarantor(1,$guarantee_message); >-is($result->{'status'}, "failed", "With EnableRedirectGuaranteeEmail on, message fails if guarantor has no address."); >- > $guarantee->{'guarantorid'} = undef; > ModMember(%$guarantee); > $result = SendToGuarantor(1,$guarantee_message); >diff --git a/t/db_dependent/Members.t b/t/db_dependent/Members.t >index 6009d10..f60bba2 100755 >--- a/t/db_dependent/Members.t >+++ b/t/db_dependent/Members.t >@@ -17,7 +17,7 @@ > > use Modern::Perl; > >-use Test::More tests => 79; >+use Test::More tests => 81; > use Test::MockModule; > use Data::Dumper; > use C4::Context; >@@ -184,7 +184,7 @@ C4::Context->set_preference( 'EnableRedirectGuaranteeEmail', 1 ); > C4::Context->clear_syspref_cache(); > > $notice_email = GetNoticeEmailAddress($guarantee->{'borrowernumber'}); >-is ($notice_email, $EMAILPRO, "GetNoticeEmailAddress returns correct value when EnableRedirectGuaranteeEmail is activated"); >+is ($notice_email, "$GUARANTEE_EMAIL,$EMAILPRO", "GetNoticeEmailAddress returns correct value when EnableRedirectGuaranteeEmail is activated"); > > > ok(!$member->{is_expired}, "GetMemberDetails() indicates that patron is not expired"); >@@ -328,7 +328,7 @@ my $borrower2 = $builder->build({ > }, > }); > >-my $guarantee = $builder->build({ >+$guarantee = $builder->build({ > source => 'Borrower', > value => { > categorycode=>'KIDclamp', >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11879
:
25745
|
25922
|
25941
|
31300
|
31301
|
31320
|
34351
|
34482
|
34502
|
34503
|
34571
|
34572
|
34573
|
41209
|
41220
|
41221
|
41222
|
46101
|
46284
|
46285
|
46286
|
48073
|
48074
|
48075
|
48076
|
48077
|
48078
|
48079
|
48556
|
48557
|
48558
|
48559
|
50433
|
52607
|
52608
|
52614
|
52615
|
52616
|
52617
|
52618
|
52619
|
52620
|
53229
|
53688
|
53695
|
53705
|
53707
|
53708
|
53709
|
53710
|
53711
|
53712
|
53713
|
55946
|
56285
|
56286
|
58580
|
58591
|
58592
|
58593
|
63238
|
63239
|
65811
|
65812
|
69028
|
69029
|
69050
|
71955
|
71956
|
71957
|
71958
|
72632
|
72633
|
72634
|
72635
|
73987
|
73988
|
73989
|
73990
|
74123
|
74124
|
74125
|
74126
|
74818
|
75652
|
83757
|
83758
|
84017
|
84018
|
84019
|
84020
|
84021
|
84022
|
88358
|
88359
|
88360
|
88361
|
88362
|
88363
|
88394
|
88395
|
88396
|
88397
|
88398
|
88399
|
88400
|
93850
|
93851
|
93852
|
93853
|
93854
|
93855
|
93856
|
93900
|
93901
|
94456
|
94457
|
94458
|
94459
|
94460
|
94461
|
94463
|
94464
|
94465
|
94466
|
94467
|
94468
|
96432
|
100817
|
100843
|
112062
|
112063
|
112064
|
112557
|
112559
|
112560
|
118959
|
118960
|
118961
|
118962
|
118985
|
118986
|
118987
|
118988
|
120947
|
120948
|
120949
|
120950
|
122778